-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[senechome] Fix ArrayIndexOutOfBoundsException
when less than 4 packs
#17299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
added
bug
An unexpected problem or unintended behavior of an add-on
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
labels
Aug 19, 2024
jimtng
changed the title
[senechome] Fix
[senechome] Fix Aug 20, 2024
ArrayIndexOutOfBoundsException
when less then 4 packsArrayIndexOutOfBoundsException
when less than 4 packs
lsiepel
removed
the
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
label
Aug 24, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Would be a candidate for cherry picking into 4.2.x |
lolodomo
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
lsiepel
added a commit
that referenced
this pull request
Sep 9, 2024
…ks (#17299) * Fix issue and warnings * Fix operator Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
added
the
patch
A PR that has been cherry-picked to a patch release branch
label
Sep 9, 2024
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Sep 24, 2024
…ks (openhab#17299) * Fix issue and warnings * Fix operator Signed-off-by: Leo Siepel <leosiepel@gmail.com>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…ks (openhab#17299) * Fix issue and warnings * Fix operator Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…ks (openhab#17299) * Fix issue and warnings * Fix operator Signed-off-by: Leo Siepel <leosiepel@gmail.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…ks (openhab#17299) * Fix issue and warnings * Fix operator Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayIndexOutOfBoundsException
after battery module change to LFP (Senec Home V3) #17298Test jar (openHAB 4.2.0+): https://1drv.ms/u/s!AnMcxmvEeupwjv9z4GKsp4RZxpWAFg?e=FpXAc9