Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[senechome] Fix ArrayIndexOutOfBoundsException when less than 4 packs #17299

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Aug 19, 2024

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Aug 19, 2024
@lsiepel lsiepel requested a review from vctender as a code owner August 19, 2024 22:35
@jimtng jimtng changed the title [senechome] Fix ArrayIndexOutOfBoundsException when less then 4 packs [senechome] Fix ArrayIndexOutOfBoundsException when less than 4 packs Aug 20, 2024
@lsiepel lsiepel removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Aug 24, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Copy link
Contributor Author

lsiepel commented Aug 31, 2024

Would be a candidate for cherry picking into 4.2.x

@lsiepel lsiepel requested a review from a team August 31, 2024 08:18
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit e4ab0e9 into openhab:main Sep 9, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Sep 9, 2024
@lsiepel lsiepel deleted the senec-multi-pack branch September 9, 2024 17:22
lsiepel added a commit that referenced this pull request Sep 9, 2024
…ks (#17299)

* Fix issue and warnings
* Fix operator

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Sep 9, 2024
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
…ks (openhab#17299)

* Fix issue and warnings
* Fix operator

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…ks (openhab#17299)

* Fix issue and warnings
* Fix operator

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…ks (openhab#17299)

* Fix issue and warnings
* Fix operator

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…ks (openhab#17299)

* Fix issue and warnings
* Fix operator

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[senechome] ArrayIndexOutOfBoundsException after battery module change to LFP (Senec Home V3)
2 participants