Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[veluxklf200] Velux Binding initial contribution #4416

Closed
wants to merge 7 commits into from

Conversation

mfk-01
Copy link

@mfk-01 mfk-01 commented Dec 21, 2018

New OH2 Binding for operating the Velux KLF200 device with firmware v2.x installed. The binding is capable of both discovering and operating both scenes and individual velux nodes (such as blinds).

Velux KLF200 (For FW2+)

The Velux KLF200 is a bridge that enables the integration and automation of Velux nodes such as automated blinds. The KLF200 communicates natively with existing Velux products using the io-homecontrol protocol. This is a closed protocol. The KLF200 bridge makes devices using this protocol available over a standard ethernet network (through an API).

The original version of the KLF200 (running firmware version 0.1.xx.xx) provided a HTTP based API. However in 2018, Velux release v2 firmware for the device and completely changed the way the KLF200 API operated. Once upgraded to v2 firmware, the HTTP based API was removed in favor of a web-sockets protocol based around the SLIP protocol.

This binding is intended to be used for KLF200 devices running firmware version 0.2.x.x.x.x. and gives complete control over individual nodes.

@wborn
Copy link
Member

wborn commented Dec 21, 2018

Thanks! Do you know if the other Velux Binding PR is based on the v1 firmware and thus obsolete?

@wborn wborn changed the title Signed-off-by: MFK <mfkeenan@gmail.com> (github: mfk-01) [velux] Velux Binding initial contribution Dec 21, 2018
@wborn wborn added the new binding If someone has started to work on a binding. For a new binding PR. label Dec 21, 2018
@wborn wborn changed the title [velux] Velux Binding initial contribution [veluxklf200] Velux Binding initial contribution Dec 21, 2018
@mfk-01
Copy link
Author

mfk-01 commented Dec 21, 2018

Hi wborn, as far as I know, the other binding does two things:
For OH2 - It only works for the KLF200 F/W versions 0.1.xxxx (which is now obsolete and no longer available)

For OH1 - It does support KLF200 F/W version 0.2.xxxx, but only activation of scenes. You cannot control individual devices.

I created this binding for myself because I upgrade to KLF200 F/W 2.x and was subsequently unable to control my Velux products in OH. As it worked so well, thought I could contribute it!

Regards,
MFK

PS - I made sure that I followed all of the pre-requisite checks on the code / style / standards before submitting the Pull request. However, there seems to be an issue with the CI build in relation to POM parents. Any pointers on what I am doing wrong? thanks,

@mfk-01
Copy link
Author

mfk-01 commented Dec 21, 2018

Also, I struggled to modify one file to add a "signed-off-by" and in trying to fix that up, have made some more commits that have screwed up everything I think. Stuck now with nowhere to go!

@wborn
Copy link
Member

wborn commented Dec 21, 2018

Thanks for the explanation.

@gs4711 do you have plans to update your Velux Binding to the new firmware or would it be OK to continue with this PR? Maybe you both can team up to create one binding?

However, there seems to be an issue with the CI build in relation to POM parents

This week openHAB 2.4.0 got released so you'll need to update all version references from 2.4.0-SNAPSHOT to 2.5.0-SNAPSHOT.

Stuck now with nowhere to go!

Clicking on the Details button shows which commits are missing a proper sign off.

The easiest way to fix it is to squash all commits into one (Stack Overflow CLI example) and making sure the commit message ends with the Signed-off-by: line. Please also add your full name instead of using your initials "MFK". 🙂

@gs4711
Copy link
Contributor

gs4711 commented Dec 21, 2018 via email

Signed-off-by: MFK <mfkeenan@gmail.com> (git MFK-01)
@Hilbrand
Copy link
Member

The original velux pr(#2531) by the author of the openhab1 version of this binding is being actively developed so I think it's doesn't add much to get this pr ready and merged as it's not interesting to have 2 different bindings for the same devices. Can we close this pr? What do you think @mfk-01 ?

@Hilbrand Hilbrand added duplicate stale As soon as a PR is marked stale, it can be removed 6 months later. labels Nov 5, 2019
@J-N-K
Copy link
Member

J-N-K commented Apr 4, 2020

Closing since #2531 has been merged. If teherare any feature missing, please add them in a new PR.

@J-N-K J-N-K closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate new binding If someone has started to work on a binding. For a new binding PR. stale As soon as a PR is marked stale, it can be removed 6 months later.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants