Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sagercaster] Sager Weather Caster Binding initial contribution #4754

Merged
merged 25 commits into from
Apr 5, 2020
Merged

[sagercaster] Sager Weather Caster Binding initial contribution #4754

merged 25 commits into from
Apr 5, 2020

Conversation

clinique
Copy link
Contributor

No description provided.

@clinique clinique requested a review from a team as a code owner January 29, 2019 14:51
@wborn wborn added new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged labels Jan 29, 2019
@wborn wborn changed the title [WIP] Sager Weather Caster binding port to OH2 [sagercaster][WIP] Sager Weather Caster Binding initial contribution Jan 30, 2019
@clinique clinique changed the title [sagercaster][WIP] Sager Weather Caster Binding initial contribution [sagercaster]Sager Weather Caster Binding initial contribution Apr 8, 2019
@clinique clinique force-pushed the Sager branch 2 times, most recently from 96b4499 to ae1bd99 Compare April 12, 2019 11:25
@clinique clinique removed the work in progress A PR that is not yet ready to be merged label May 9, 2019
@wborn wborn changed the title [sagercaster]Sager Weather Caster Binding initial contribution [sagercaster] Sager Weather Caster Binding initial contribution May 25, 2019
@martinvw martinvw added the cre Coordinated Review Effort label Jul 10, 2019
@Hilbrand Hilbrand added the oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 label Sep 13, 2019
@Hilbrand Hilbrand mentioned this pull request Oct 5, 2019
Closed
@cweitkamp cweitkamp self-assigned this Nov 18, 2019
@kaikreuzer kaikreuzer removed the cre Coordinated Review Effort label Dec 8, 2019
@cpmeister cpmeister changed the base branch from master to 2.5.x March 18, 2020 05:27
cpmeister
cpmeister requested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this PR isn't dead. I've gone ahead and switch the base branch to our current working branch (2.5.x) and done a quick review just to get things started. Overall I don't think that very much has to change in the binding for it to be accepted and this review is probably about it.
If you have any questions please let me know.

...g.sagercaster/src/main/java/org/openhab/binding/sagercaster/internal/SagerWeatherCaster.java Outdated Show resolved Hide resolved
...g.sagercaster/src/main/java/org/openhab/binding/sagercaster/internal/SagerWeatherCaster.java Outdated Show resolved Hide resolved
...g.sagercaster/src/main/java/org/openhab/binding/sagercaster/internal/SagerWeatherCaster.java Outdated Show resolved Hide resolved
...aster/src/main/java/org/openhab/binding/sagercaster/internal/handler/SagerCasterHandler.java Outdated Show resolved Hide resolved
...aster/src/main/java/org/openhab/binding/sagercaster/internal/handler/SagerCasterHandler.java Outdated Show resolved Hide resolved
...aster/src/main/java/org/openhab/binding/sagercaster/internal/handler/SagerCasterHandler.java Outdated Show resolved Hide resolved
...aster/src/main/java/org/openhab/binding/sagercaster/internal/handler/SagerCasterHandler.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.sagercaster/src/main/resources/ESH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.sagercaster/src/main/resources/ESH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
features/karaf/openhab-addons/src/main/feature/feature.xml Outdated Show resolved Hide resolved
@openhab openhab deleted a comment from TravisBuddy Mar 18, 2020
@openhab openhab deleted a comment from TravisBuddy Mar 18, 2020
@openhab openhab deleted a comment from TravisBuddy Mar 18, 2020
@clinique clinique requested a review from cpmeister March 18, 2020 13:36
@openhab openhab deleted a comment from TravisBuddy Mar 18, 2020
@openhab openhab deleted a comment from TravisBuddy Mar 18, 2020
@openhab openhab deleted a comment from TravisBuddy Mar 18, 2020
@openhab openhab deleted a comment from TravisBuddy Mar 18, 2020
@cweitkamp
Copy link
Contributor

Or you introduce specific profiles which handle the conversion for this binding.

@clinique
Copy link
Contributor Author

clinique commented Apr 4, 2020

Or you introduce specific profiles which handle the conversion for this binding.

Could be an option...for an update of the binding :) ?

@clinique
Give flexibility over the rain related channel
1e74db7 
Signed-off-by: clinique <gael@lhopital.org>
@cpmeister
Copy link
Contributor

Or you introduce specific profiles which handle the conversion for this binding.

Could be an option...for an update of the binding :) ?

Yea, save that for a later PR. :)

@clinique
Some more complements after code review
fc9a690 
Signed-off-by: clinique <gael@lhopital.org>
@openhab openhab deleted a comment from TravisBuddy Apr 5, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @clinique,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cweitkamp
Copy link
Contributor

I think it is time to merge this migration now. Any objections @cpmeister?

@clinique clinique requested a review from cpmeister April 5, 2020 09:18
@cpmeister
Copy link
Contributor

You should also leave a note in the readme so users know what either the is-raining or the rain-qtty can be used. The way it is written right now makes it look like both of the channels are required.

@clinique
Doc enhancement
3a24661 
Signed-off-by: clinique <gael@lhopital.org>
@TravisBuddy
Copy link

Travis tests were successful

Hey @clinique,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cpmeister cpmeister merged commit 0ef20dc into openhab:2.5.x Apr 5, 2020
@cpmeister cpmeister added this to the 2.5.4 milestone Apr 5, 2020
@cweitkamp cweitkamp removed the cre Coordinated Review Effort label Apr 5, 2020
@clinique clinique deleted the Sager branch April 10, 2020 13:04
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
@clinique @Hans-Reiner
[sagercaster] Sager Weather Caster Binding initial contribution (open…
cdbdd2e 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@clinique
[sagercaster] Sager Weather Caster Binding initial contribution (open…
2594ce9 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@clinique @markus7017
[sagercaster] Sager Weather Caster Binding initial contribution (open…
d3593d9 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@clinique @LoungeFlyZ
[sagercaster] Sager Weather Caster Binding initial contribution (open…
8f2d8dc 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@clinique @J-N-K
[sagercaster] Sager Weather Caster Binding initial contribution (open…
c7568ac 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@clinique @CSchlipp
[sagercaster] Sager Weather Caster Binding initial contribution (open…
414d255 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[sagercaster] Sager Weather Caster Binding initial contribution (open…
68f256c 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[sagercaster] Sager Weather Caster Binding initial contribution (open…
32943b5 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[sagercaster] Sager Weather Caster Binding initial contribution (open…
c3e9490 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[sagercaster] Sager Weather Caster Binding initial contribution (open…
592b144 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@clinique @DaanMeijer
[sagercaster] Sager Weather Caster Binding initial contribution (open…
7ea08fc 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@clinique @markus7017
[sagercaster] Sager Weather Caster Binding initial contribution (open…
19c6376 
…hab#4754)

* First commit of v2 SagerCaster Binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

@J-N-K J-N-K Awaiting requested review from J-N-K

@martinvw martinvw Awaiting requested review from martinvw

@cpmeister cpmeister Awaiting requested review from cpmeister

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
8 participants
@clinique @cweitkamp @cpmeister @TravisBuddy @Hilbrand @martinvw @kaikreuzer @wborn