Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nikobus ]Added address as parameter and not using id anymore + updated readme. #6284

Merged
merged 1 commit into from
Nov 1, 2019
Merged

[nikobus ]Added address as parameter and not using id anymore + updated readme. #6284

merged 1 commit into from
Nov 1, 2019

Conversation

crnjan
Copy link
Contributor

@crnjan crnjan commented Oct 25, 2019

Should resolve pending issues for Nikobus v2 binding, as discussed in #6181.

Signed-off-by: Boris Krivonog boris.krivonog@inova.si

@TravisBuddy
Copy link

Travis tests were successful

Hey @crnjan,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@crnjan crnjan changed the title Added address as parameter and not using id anymore + updated readme. [nikobus ]Added address as parameter and not using id anymore + updated readme. Oct 25, 2019
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/nikobus-v2/80241/56

@TravisBuddy
Copy link

Travis tests were successful

Hey @crnjan,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
@TravisBuddy
Copy link

Travis tests were successful

Hey @crnjan,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, many thanks!

@kaikreuzer kaikreuzer merged commit 2d4b801 into openhab:master Nov 1, 2019
roieg pushed a commit to roieg/openhab-addons that referenced this pull request Nov 3, 2019
…openhab#6284)

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Signed-off-by: Roie Geron <roie.geron@satixfy.com>
roieg pushed a commit to roieg/openhab-addons that referenced this pull request Nov 3, 2019
…openhab#6284)

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Signed-off-by: Roie Geron <roie.geron@satixfy.com>
thewiep pushed a commit to thewiep/openhab-addons that referenced this pull request Nov 23, 2019
roieg pushed a commit to roieg/openhab-addons that referenced this pull request Nov 28, 2019
@wborn wborn added this to the 2.5 milestone Dec 7, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Dec 8, 2019
roieg pushed a commit to roieg/openhab-addons that referenced this pull request Dec 25, 2019
roieg pushed a commit to roieg/openhab-addons that referenced this pull request Dec 26, 2019
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
…openhab#6284)

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
hww3 pushed a commit to hww3/openhab2-addons that referenced this pull request Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants