Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InfluxDB] Old binding port & some improvements - Initial contribution #6507

Closed
wants to merge 4 commits into from

Conversation

dominikkv
Copy link

I have ported the openhab1-addons binding of InfluxDB to the openhab2-addons repository. Doing this I have done some improvements:

This version is compatibel with the old version, that means you can use your old config and everything is still working.

I am not sure if we can use the same name as the old binding?

See also community thread https://community.openhab.org/t/updated-influxdb-binding-with-tags/79645

Thanks for any feedback, I'm happy to improve this PR with your help!

Signed-off-by: Dominik Vorreiter dominikkv@gmx.de

Fixes openhab/openhab1-addons#4830
Fixes openhab/openhab1-addons#5907
Fixes openhab/openhab1-addons#5888

Dominik

Signed-off-by: Dominik Vorreiter <dominikkv@gmx.de>
Signed-off-by: Dominik Vorreiter <dominikkv@gmx.de>
Signed-off-by: Dominik Vorreiter <dominikkv@gmx.de>
…private...

Signed-off-by: Dominik Vorreiter <dominikkv@gmx.de>
@dominikkv dominikkv requested a review from a team as a code owner December 4, 2019 21:43
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/updated-influxdb-binding-with-tags/79645/19

@TravisBuddy
Copy link

Travis tests were successful

Hey @dominikkv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@kaikreuzer
Copy link
Member

Thanks @dominikkv, but I am afraid, we cannot merge this.
I did this exercise a few months ago already, which resulted in
openhab/openhab-core#680, https://github.com/openhab/openhab2-addons/pull/5275 and openhab/openhab1-addons#5844.

As mentioned in openhab/openhab-core#680 (comment), we have decided to do those changes after the 2.5 release only.

It would be great though, if you could create PRs against by branch https://github.com/kaikreuzer/openhab2-addons/tree/persist with your fixes - this way, they will be included once we merge this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants