-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[upb] UPB Binding initial contribution #6742
Conversation
Travis tests were successfulHey @marcusb, |
Travis tests have failedHey @marcusb, 2nd BuildExpand here
|
Travis tests have failedHey @marcusb, 2nd BuildExpand here
|
Travis tests were successfulHey @marcusb, |
Travis tests were successfulHey @marcusb, |
Travis tests were successfulHey @marcusb, |
1 similar comment
Travis tests were successfulHey @marcusb, |
Travis tests were successfulHey @marcusb, |
0f9b280
to
3223e85
Compare
Travis tests were successfulHey @marcusb, |
1 similar comment
Travis tests were successfulHey @marcusb, |
Travis tests have failedHey @marcusb, 1st BuildExpand here
|
Can you provide a JAR for testing? |
End-user testing data point here: I've tried installing & testing this UPB binding on a brand-new, clean install of OH 2.5.1. stand-alone under Mac OS X 10.14.6. Working fine in limited testing so far. Additional details at this post. |
@marcusb - you might want to pick a number of appropriate Reviewers and prompt them to look over this PR, using the "Reviewers" field at the upper left of your GitHub web browser session? |
Signed-off-by: Marcus Better <marcus@better.se>
CI build seems to be successful but timing out just at the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just 2 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed your code and here is my feedback. Only some minor things.
bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/Constants.java
Outdated
Show resolved
Hide resolved
...es/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/SerialIoThread.java
Outdated
Show resolved
Hide resolved
...es/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/SerialIoThread.java
Outdated
Show resolved
Hide resolved
.../org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/SerialPIMHandler.java
Outdated
Show resolved
Hide resolved
...s/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/UPBThingChannel.java
Outdated
Show resolved
Hide resolved
...s/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/UPBThingHandler.java
Outdated
Show resolved
Hide resolved
...g.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/VirtualThingHandler.java
Outdated
Show resolved
Hide resolved
...rg.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java
Show resolved
Hide resolved
bundles/org.openhab.binding.upb/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.upb/src/main/resources/ESH-INF/thing/virtual.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
When a receive timeout is configured, a read() on the serial input will return -1 if the timeout elapses with no data available. We should not treat this as EOF. Also, by waking up the serial thread every 100ms, we can shut it down gracefully. Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fwolter Can you can a last look and merge if deemed oke? |
Thanks for the reviews! |
Signed-off-by: Marcus Better <marcus@better.se>
No description provided.