-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[epsonprojector] Port of the OH 1.x epsonprojector binding **OH3 version** #7370
Conversation
This is a straightforward port of the epsonprojector binding from OH 1.x by Pauli Antilla. Next to no changes were made to the connector code so the binding should have the same features as the original. Already supported Epson command types are mapped as channels. The only missing feature is that it is not possible anymore to configure individual polling intervals for each command type/channel; there's a global polling interval only. Signed-off-by: Yannick Schaus <github@schaus.net> # Conflicts: # bom/openhab-addons/pom.xml # bundles/pom.xml
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
openhab#6922 (review) Signed-off-by: Yannick Schaus <github@schaus.net>
Travis tests were successfulHey @ghys, |
If you are also finishing #6922 and we soon have it in the 2.5.x branch, it will be automatically ported to 3.0. |
I was switching the serial transport from Also figured maybe you'd want this to be a test of having to deal with both OH2 bindings to port and OH3-exclusive ones at the same time, since there could be more of that in the future? |
I'm fine with this being a OH3 only add-on for now. It's nice to see the serial transport being used as well. 👍 The downsides of this being an OH3 only add-on are of course that there will be less users who can easily test it. Also, if they can already migrate to it while being on OH2, they have one less manual migration to do whenever they upgrade to OH3. 😉 |
I'd say the decision is absolutely up to @ghys - both options are imho fine for us. |
Perfect, then I'm fine with it being the first OH3-only binding, if everything's fine wrt the infrastructure :) Don't worry about the testing, it's not the most used binding I suppose, so I can take care of the testing myself since I happen have plenty of opportunities to do so these days, for some reason... No rush in merging it, I can use it for a few days/weeks to confirm it's stable first. |
Signed-off-by: Yannick Schaus <github@schaus.net>
Travis tests were successfulHey @ghys, |
I stand corrected then 😄 |
Will the automatic conversion be available as a script for bindings that are not in 2.5.x? I have my own binding that I did not submit but it works with 2.5, and I might like to use it in 3.0 when it comes out. Thanks. |
Could you please re-create this PR against the |
This is the same OH1 binding port as #6922, but with the master branch as base.
(Full story: I'm in the process of switching my production to openHAB 3 so I needed to make this binding OH3-compatible.)
@kaikreuzer @wborn @openhab/add-ons-maintainers I don't know if it is a good time to add new bindings to the master branch yet... anyways here it is just in case, and I'm keeping #6922 open for you to decide, but I'd prefer to work on this one now since it's more difficult for me to develop & test the OH2.5 version.
This also includes the latest review comments by @cpmeister.
Signed-off-by: Yannick Schaus github@schaus.net