Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamodb] Fix CallItem IT, ZonedDateTime into wide use #7598

Merged
merged 1 commit into from
May 13, 2020
Merged

[dynamodb] Fix CallItem IT, ZonedDateTime into wide use #7598

merged 1 commit into from
May 13, 2020

Conversation

ssalonen
Copy link
Contributor

No description provided.

@ssalonen ssalonen requested a review from a team as a code owner May 11, 2020 05:43
@ssalonen ssalonen mentioned this pull request May 11, 2020
Merged
@TravisBuddy
Copy link

Travis tests were successful

Hey @ssalonen,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cweitkamp
cweitkamp requested changes May 11, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you please signed-off your commit(s).

@cweitkamp cweitkamp added the enhancement An enhancement or new feature for an existing add-on label May 11, 2020
@cweitkamp cweitkamp added this to the 3.0 milestone May 11, 2020
@ssalonen
[dynamodb] Fix CallItem IT, ZonedDateTime into wide use
b2fb652 
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen ssalonen force-pushed the dynamodb-java11-and-other-fixes branch from 80ccfbe to b2fb652 Compare May 12, 2020 04:40
@TravisBuddy
Copy link

Travis tests were successful

Hey @ssalonen,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 6196a23 into openhab:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp requested changes

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ssalonen @TravisBuddy @cpmeister @cweitkamp