-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freebox] Removed dependency on 'org.apache.commons.lang' #7727
Conversation
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
This was pushed without a working maven buiuld (Maven build is currently not working due to download failures). |
Relative to #7722 |
Travis tests were successfulHey @lolodomo, |
...ox/src/main/java/org/openhab/binding/freebox/internal/discovery/FreeboxDiscoveryService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the discussion about removing the dependency, but given we want it this looks good.
Travis tests were successfulHey @lolodomo, |
Using the offline mode ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [freebox] Removed dependency on 'org.apache.commons.lang' * Use variables Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [freebox] Removed dependency on 'org.apache.commons.lang' * Use variables Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [freebox] Removed dependency on 'org.apache.commons.lang' * Use variables Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de>
* [freebox] Removed dependency on 'org.apache.commons.lang' * Use variables Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [freebox] Removed dependency on 'org.apache.commons.lang' * Use variables Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [freebox] Removed dependency on 'org.apache.commons.lang' * Use variables Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [freebox] Removed dependency on 'org.apache.commons.lang' * Use variables Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [freebox] Removed dependency on 'org.apache.commons.lang' * Use variables Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
* [freebox] Removed dependency on 'org.apache.commons.lang' * Use variables Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier lg.hc@free.fr