-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonos] Removed dependency on 'org.apache.commons.io.IOUtils' #7730
Conversation
This was pushed without a working maven buiuld (Maven build is currently not working due to download failures). |
Relative to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Travis tests were successfulHey @lolodomo, |
Signed-off-by: Laurent Garnier <lg.hc@]free.fr>
Using the offline mode ( |
Travis tests were successfulHey @lolodomo, |
@@ -115,7 +114,11 @@ public void process(AudioStream audioStream) | |||
logger.warn("We do not have any callback url, so Sonos cannot play the audio stream!"); | |||
} | |||
} else { | |||
IOUtils.closeQuietly(audioStream); | |||
try { | |||
audioStream.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I once again have to jump into the discussion if we really have to close the passed AudioStream
in AudioSink
implementations. IIRC Chromecast and Kodi do not close it and I am not aware of any resource leak. Maybe we can find a final decision on it in openhab/openhab-core#532.
At the end we should make it clear in the JavaDoc for the Audiosink#process(AudioStream) method.
As it is apparently not clear if the audio stream has to be closed or not, I close my change proposal until this point is clearer. |
Relative to #7722
Signed-off-by: Laurent Garnier lg.hc@free.fr