[http] Initial contribution

[J-N-K]

This adds a new HTTP binding as a replacement for the old http1 binding.

Replaces #7851

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

[TravisBuddy]

Hey @J-N-K,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 95074880-04e0-11eb-a4bc-1b94c014fd22

[kaikreuzer]

PR build asks you to apply spotless to the pom.xml.

[J-N-K]

@openhab/add-ons-maintainers Can we get a second review here? Would be great to have this in M3, so people using http1 can move on to OH3

[fwolter]

Good code in general. I'm not aware of the current null check implementations, but I receive 3 warnings when compiling with maven.

I don't really like that you use unchecked exceptions all over the code, because the compiler doesn't enforce you to catch those. Normally I would claim this as error prone, but I think you know what you're doing.

[fwolter]

By reading the documentation I don't understand what these special values are about. Are they searched in the response body respectively sent in the body?

[J-N-K]

If the response (after transformation) is equal to that value, it is interpreted as ON (e.g. a response could be true, 1 or eingeschalltet).

[fwolter]

Can you put this sentence in the readme? I think it would help the user to understand how this binding is actually working, as you don't provide examples.

When thinking about how this works, I also wouldn't know what to set the transformation parameters to. I think a full example would be really helpful.

[J-N-K]

I added a note for the special values and also examples for the transformation

[J-N-K]

Regarding the checked/unchecked exceptions: Unfortunately an unchecked exception leads to a better code style.

refreshingUrlCache.get().ifPresent(itemValueConverter::process);

is not possible if ItemValueConverter.process(Content content) throws a check exception. The exception handling would need to be done insinde of ifPresent.

[fwolter]

Can you put this sentence in the readme? I think it would help the user to understand how this binding is actually working, as you don't provide examples.

When thinking about how this works, I also wouldn't know what to set the transformation parameters to. I think a full example would be really helpful.

[fwolter]

LGTM