[MyQ] Initial commit of the MyQ binding for OH3 #9347

digitaldan · 2020-12-12T17:20:17Z

Signed-off-by: Dan Cunningham dan@digitaldan.com

This introduces a new MyQ binding for openHAB to replace the 1.x version. Feedback welcome.

This will replace the 1.x myq binding referenced in #6179

morph166955 · 2020-12-13T19:37:20Z

I've tested the binary you provided. I'm getting errors in the log showing info below. The redacted JSON had all my info in it so I'm assuming it did in fact find my account.

2020-12-13 13:35:05.518 [INFO ] [me.event.ThingStatusInfoChangedEvent] - Thing 'myq:account:home' changed from UNKNOWN to ONLINE
2020-12-13 13:35:05.615 [INFO ] [me.event.ThingStatusInfoChangedEvent] - Thing 'myq:account:home' changed from ONLINE to OFFLINE (COMMUNICATION_ERROR): Invalid Response Code 404

2020-12-13 13:49:51.725 [TRACE] [q.internal.handler.MyQAccountHandler] - Account Response - status: 200 content: {"SecurityToken":"REDACTED"}
2020-12-13 13:49:51.775 [TRACE] [q.internal.handler.MyQAccountHandler] - Account Response - status: 200 content: {"Users":{REDACTED}
2020-12-13 13:49:51.826 [TRACE] [q.internal.handler.MyQAccountHandler] - Account Response - status: 404 content: {"code":"404.401","message":"Not Found","description":"Account not found."}

digitaldan · 2020-12-13T20:51:17Z

Are you configuring this with things files? Auto discovery ? Can you describe the steps you took to configure this? Also it seems the jar you have might be a few revisions behind (logging looks outdated). Can you download again from https://github.com/digitaldan/openhab-addons/releases/tag/myq-wip-1 ? I update that with the last build time and a new jar instead of creating new revisions. Any other logging or info would be helpful. Thanks!

digitaldan · 2020-12-13T20:54:42Z

Actually the logging does not look outdated, my guess is you do have a updated version, so info on how you configured this would be helpful, thanks!

morph166955 · 2020-12-13T20:59:58Z

Configured as:

Bridge myq:account:home "MyQ Account" [ username="my@mail.com",password="shhhhhh",refreshInterval=60 ] {
        Thing garagedoor ABCDE "Double Garage Door" [ serialNumber="ABCDE" ]
        Thing garagedoor FGHIJ "Single Garage Door" [ serialNumber="FGHIJ" ]
}

I will say the JSON from the original posting looked "OK". It had my email, name, address, etc. I would assume it was a valid reply.

digitaldan · 2020-12-13T21:32:57Z

can you download org.openhab.binding.myq-3.0.0-SNAPSHOT.jar and try again? For some reason i don't think it liked the UserId i was grabbing for the account (although it works for me) , so i 'm grabbing a different one .

digitaldan · 2020-12-13T21:33:22Z

sorry , download at https://github.com/digitaldan/openhab-addons/releases/download/myq-wip-1/org.openhab.binding.myq-3.0.0-SNAPSHOT.jar

morph166955 · 2020-12-13T21:46:21Z

I'd say closer but still missing something. The JSON that starts with Users is now about twice as long as it was with the last version. I still get the 404.401 error however after that.

digitaldan · 2020-12-13T22:15:58Z

Try it again ? I missed a spot where i needed to use that new ID , thanks.

morph166955 · 2020-12-13T22:23:05Z

There we go! I'll start to test/monitor actual usage now.

digitaldan · 2020-12-13T22:44:17Z

Thanks for testing, appreciate it !

digitaldan · 2020-12-20T18:48:43Z

This is now ready for review, thanks!

morph166955 · 2020-12-20T19:23:21Z

Do you have a final JAR you want me to test out to confirm it's all solid here?

digitaldan · 2020-12-20T20:48:20Z

Sure, i just updated:
https://github.com/digitaldan/openhab-addons/releases/download/myq-wip-1/org.openhab.binding.myq-3.0.0-SNAPSHOT.jar

digitaldan · 2020-12-24T22:06:42Z

@computergeek1507 thanks for helping with the light. I'm not sure how you made those changes as i don't see a branch they were committed from or a sign off message. In fact , some how you modified my personal branch on my repo. If we change that UID to lamp, we also need to modify the thing definition to match, i will update that myself, and make sure things compile and work as much as i can..

digitaldan · 2020-12-24T22:08:42Z

@computergeek1507 is it possible to remove your changes? I'm not sure now how to get my branch in sync with those changes.

bundles/org.openhab.binding.myq/pom.xml

digitaldan · 2020-12-26T04:14:48Z

@computergeek1507 I updated the binding to use "lamp" vs "light" throughout the binding so there is consistency with the MyQ naming conventions. I updated the jar at https://github.com/digitaldan/openhab-addons/releases/download/myq-wip-1/org.openhab.binding.myq-3.0.0-SNAPSHOT.jar with these changes. If you previously added a lamp/light, you will need to remove it and let the binding find the lamp again. Thanks for the pointer. If you have a json dump of a lamp that would be helpful.

@fwolter i will update it to the latest milestone shortly, thanks.

computergeek1507 · 2020-12-26T04:30:51Z

@digitaldan I sent the JSON to you over on the community forum

digitaldan · 2020-12-26T04:43:03Z

I totally missed that , thank you! Looking at the json and my recent changes, it seems like it should work. Let me know if thats the case or not.

digitaldan · 2020-12-26T05:13:15Z

@fwolter, done!

digitaldan · 2021-01-23T16:31:15Z

I Just rebased to main and updated license headers to get the build passing

digitaldan · 2021-01-25T16:26:40Z

👀

fwolter

Looks way better with the ThingHandlerService!

....openhab.binding.myq/src/main/java/org/openhab/binding/myq/internal/MyQDiscoveryService.java

...ab.binding.myq/src/main/java/org/openhab/binding/myq/internal/handler/MyQAccountHandler.java

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan · 2021-01-25T20:14:09Z

Thanks, changes done.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan · 2021-01-30T18:40:17Z

Unless there are any major issues, i would love to see this merged soon. Thanks.

fwolter

LGTM

digitaldan · 2021-02-02T04:11:27Z

👀

cpmeister

Only a few small suggestions.

...ab.binding.myq/src/main/java/org/openhab/binding/myq/internal/handler/MyQAccountHandler.java

Signed-off-by: Dan <dan@MacBook-Pro.digitaldan.com>

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan · 2021-02-20T18:59:27Z

Just realized my last commit was missing a sign off. Should be ready now @cpmeister

digitaldan · 2021-02-23T03:44:22Z

👀

digitaldan · 2021-02-25T22:44:29Z

👀 😢

cpmeister

LGTM

morph166955 · 2021-02-27T19:22:14Z

Updated to S2225 which includes this. Everything looks good. Thank you @digitaldan !!!!!

openhab-bot · 2021-03-01T00:16:56Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/newbie-question-myq-binding/118091/2

* Rebase with main, update license headers * Small PR cleanups * One last small PR cleanup * Syntactical sugar * Updated error handling * Spelling mistake Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>

* Rebase with main, update license headers * Small PR cleanups * One last small PR cleanup * Syntactical sugar * Updated error handling * Spelling mistake Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan requested a review from a team as a code owner December 12, 2020 17:20

fwolter added new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 work in progress A PR that is not yet ready to be merged labels Dec 13, 2020

Hilbrand mentioned this pull request Dec 15, 2020

openHAB 1 addon compatibility overview with openHAB 3 #6179

Closed

digitaldan changed the title ~~[WIP] MyQ Initial commit of the MyQ binding for OH3~~ [MyQ] Initial commit of the MyQ binding for OH3 Dec 20, 2020

digitaldan removed the work in progress A PR that is not yet ready to be merged label Dec 20, 2020

computergeek1507 force-pushed the myq branch from df398a6 to 60c6511 Compare December 25, 2020 01:40

fwolter reviewed Dec 25, 2020

View reviewed changes

bundles/org.openhab.binding.myq/pom.xml Outdated Show resolved Hide resolved

digitaldan force-pushed the myq branch from 1f96658 to a07ac45 Compare December 26, 2020 05:11

digitaldan force-pushed the myq branch from a07ac45 to b8d83d9 Compare December 26, 2020 06:18

digitaldan force-pushed the myq branch from 9fc4734 to 7c5daf3 Compare January 23, 2021 16:30

fwolter requested changes Jan 25, 2021

View reviewed changes

digitaldan added 2 commits January 25, 2021 12:09

Small PR cleanups

91b6ef1

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

One last small PR cleanup

44ab5f4

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

Hilbrand requested a review from fwolter January 26, 2021 09:52

Syntactical sugar

37eb721

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

fwolter approved these changes Jan 30, 2021

View reviewed changes

fwolter added the cre Coordinated Review Effort label Jan 30, 2021

cpmeister requested changes Feb 4, 2021

View reviewed changes

...ab.binding.myq/src/main/java/org/openhab/binding/myq/internal/handler/MyQAccountHandler.java Outdated Show resolved Hide resolved

...ab.binding.myq/src/main/java/org/openhab/binding/myq/internal/handler/MyQAccountHandler.java Outdated Show resolved Hide resolved

Updated error handling

91d947f

Signed-off-by: Dan <dan@MacBook-Pro.digitaldan.com>

Hilbrand requested a review from cpmeister February 18, 2021 08:00

Spelling mistake

483f62d

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan force-pushed the myq branch from 283d5e6 to 483f62d Compare February 20, 2021 18:58

cpmeister approved these changes Feb 26, 2021

View reviewed changes

cpmeister merged commit 42edf53 into openhab:main Feb 26, 2021

cpmeister added this to the 3.1 milestone Feb 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MyQ] Initial commit of the MyQ binding for OH3 #9347

[MyQ] Initial commit of the MyQ binding for OH3 #9347

digitaldan commented Dec 12, 2020 •

edited

Loading

morph166955 commented Dec 13, 2020 •

edited

Loading

digitaldan commented Dec 13, 2020

digitaldan commented Dec 13, 2020

morph166955 commented Dec 13, 2020 •

edited

Loading

digitaldan commented Dec 13, 2020

digitaldan commented Dec 13, 2020

morph166955 commented Dec 13, 2020

digitaldan commented Dec 13, 2020

morph166955 commented Dec 13, 2020

digitaldan commented Dec 13, 2020

digitaldan commented Dec 20, 2020

morph166955 commented Dec 20, 2020

digitaldan commented Dec 20, 2020

digitaldan commented Dec 24, 2020

digitaldan commented Dec 24, 2020

digitaldan commented Dec 26, 2020

computergeek1507 commented Dec 26, 2020

digitaldan commented Dec 26, 2020

digitaldan commented Dec 26, 2020

digitaldan commented Jan 23, 2021

digitaldan commented Jan 25, 2021

fwolter left a comment

digitaldan commented Jan 25, 2021

digitaldan commented Jan 30, 2021

fwolter left a comment

digitaldan commented Feb 2, 2021

cpmeister left a comment

digitaldan commented Feb 20, 2021

digitaldan commented Feb 23, 2021

digitaldan commented Feb 25, 2021

cpmeister left a comment

morph166955 commented Feb 27, 2021

openhab-bot commented Mar 1, 2021

[MyQ] Initial commit of the MyQ binding for OH3 #9347

[MyQ] Initial commit of the MyQ binding for OH3 #9347

Conversation

digitaldan commented Dec 12, 2020 • edited Loading

morph166955 commented Dec 13, 2020 • edited Loading

digitaldan commented Dec 13, 2020

digitaldan commented Dec 13, 2020

morph166955 commented Dec 13, 2020 • edited Loading

digitaldan commented Dec 13, 2020

digitaldan commented Dec 13, 2020

morph166955 commented Dec 13, 2020

digitaldan commented Dec 13, 2020

morph166955 commented Dec 13, 2020

digitaldan commented Dec 13, 2020

digitaldan commented Dec 20, 2020

morph166955 commented Dec 20, 2020

digitaldan commented Dec 20, 2020

digitaldan commented Dec 24, 2020

digitaldan commented Dec 24, 2020

digitaldan commented Dec 26, 2020

computergeek1507 commented Dec 26, 2020

digitaldan commented Dec 26, 2020

digitaldan commented Dec 26, 2020

digitaldan commented Jan 23, 2021

digitaldan commented Jan 25, 2021

fwolter left a comment

Choose a reason for hiding this comment

digitaldan commented Jan 25, 2021

digitaldan commented Jan 30, 2021

fwolter left a comment

Choose a reason for hiding this comment

digitaldan commented Feb 2, 2021

cpmeister left a comment

Choose a reason for hiding this comment

digitaldan commented Feb 20, 2021

digitaldan commented Feb 23, 2021

digitaldan commented Feb 25, 2021

cpmeister left a comment

Choose a reason for hiding this comment

morph166955 commented Feb 27, 2021

openhab-bot commented Mar 1, 2021

digitaldan commented Dec 12, 2020 •

edited

Loading

morph166955 commented Dec 13, 2020 •

edited

Loading

morph166955 commented Dec 13, 2020 •

edited

Loading