-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed dependency on 'org.apache.commons.lang' #1433
Removed dependency on 'org.apache.commons.lang' #1433
Conversation
04f0ca2
to
bc24a35
Compare
bc24a35
to
510049f
Compare
OHC code is clean now. But it will completely break openHAB add-ons. Thus I did not yet remove the import from BOM nor resolved the itests. |
The task list suggests you want to keep working on this but you did remove the WIP label? |
Removed in openhab/openhab-core#1433.
ScriptUtils is only used in one JS example script in any of the helper libraries, which I have created a PR to remove. I'm doubtful there will be much of an impact to peoples' scripts. I'm sure there is a good reason, but I'm curious why this is being removed. |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
510049f
to
46e6b85
Compare
It is more or less a reminder. In general I wanted to ask for your opinion. How should we proceed? Remove everything in OHC right now and break OH3 add-ons build or try to find a solution for add-ons. Do we currently continue to allow
One of our open items on the roadmap for OH3 is to remove dependency on |
We need to refactor addons anyway to remove commons-lang, right? So we could do it now, it shpuld not break anything that faces the user, so it is fully backward-compatible. |
We can already replace all usages in the core and keep the Maven dependency for now so the OH3 add-ons port keeps working. For some changes such as using That way this PR won't collect merge conflicts and we can slowly progress to fully removing the dependency. |
That was exactly my idea and the purpose of leaving BOM and features untouched. Resolving the |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! As the changes show, the library no longer provides us with a lot of added value.
Great. I will try to continue with |
Can you help me with which change |
I think |
Hm, ok, thanks - interesting side-effect. |
A quick search reveals three: freebox, loxone and millheat. They are using methods to decode/encode hex strings to byte arrays. We can replace them by OHC |
"We can" - I assume you are talking in majestic plural and am looking forward to your PR - thanks! 🥇 |
"We" created a PR to fix it openhab/openhab-addons#7460 |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/guide-binding-development-changes-for-openhab-3-from-2-5-x/104134/4 |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-3-0-milestone-2-discussion/107564/131 |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> GitOrigin-RevId: d371a34
Removed dependency on
org.apache.commons.lang
bom/compile/pom.xml
bom/compile/pom.xml
features/karaf/openhab-tp/src/main/feature/feature.xml
Resolve
itest.bndrun
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de