[Sitemap] Accept an optional icon for each value/label mapping #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set by the user, the icon can be used by UIs for switch element with mappings to render a button with the icon rather than the label. Related to openhab#3441 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
It is an enhancement of the sitemap syntax and of the sitemap REST API. |
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Sep 23, 2023
Related to openhab/openhab-core#3441 Depends on openhab/openhab-core#3809 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Sep 24, 2023
Related to openhab/openhab-core#3441 Depends on openhab/openhab-core#3809 Icons will not be used if icons are nbot enabled (app setting). Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
@openhab/core-maintainers : would it be possible to consider this PR relatively soon to let time to each sitemap UI to implement the new feature before OH 4.1 is released? |
kaikreuzer
reviewed
Oct 1, 2023
...ore.ui/src/main/java/org/openhab/core/ui/internal/components/UIComponentSitemapProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Rebase done solving the conflict and your comment considered. |
|
Thank you Kai. |
kaikreuzer
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Oct 3, 2023
Related to openhab/openhab-core#3441 Depends on openhab/openhab-core#3809 Icons will not be used if icons are not enabled (app setting). Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-docs
that referenced
this pull request
Nov 4, 2023
Related to openhab/openhab-core#3809 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
stefan-hoehn
pushed a commit
to openhab/openhab-docs
that referenced
this pull request
Nov 18, 2023
Related to openhab/openhab-core#3809 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set by the user, the icon can be used by UIs for switch element with mappings to render a button with the icon rather than the label.
Related to #3441
Signed-off-by: Laurent Garnier lg.hc@free.fr