Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSL] Expose ColorUtil methods to DSL rules #3879

Merged
merged 1 commit into from
Nov 22, 2023
Merged

[DSL] Expose ColorUtil methods to DSL rules #3879

merged 1 commit into from
Nov 22, 2023

Conversation

holgerfriedrich
Copy link
Member

New functions for RGBW introduced in #3849.

Just direction HsbToRgb. Opposite direction uses existing function which returns array of size 4 instead of 3.

@holgerfriedrich
[DSL] Expose ColorUtil methods to DSL rules
5d86b77 
New functions for RGBW introduced in openhab#3849.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner November 21, 2023 17:28
@holgerfriedrich
Copy link
Member Author

holgerfriedrich commented Nov 21, 2023 •
edited
Loading

@genesis81 @lolodomo FYI

@lolodomo
Copy link
Contributor

Thank you @holgerfriedrich .
Once merged, please also update the documentation.
See my initial doc contribution:
openhab/openhab-docs#2154

kaikreuzer
kaikreuzer approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 3e3afd8 into openhab:main Nov 22, 2023
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.1 milestone Nov 22, 2023
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Nov 22, 2023
@holgerfriedrich holgerfriedrich mentioned this pull request Dec 3, 2023
Merged
@holgerfriedrich holgerfriedrich deleted the pr-colorutil-dsl branch December 16, 2023 10:41
@holgerfriedrich holgerfriedrich mentioned this pull request Jan 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@holgerfriedrich @lolodomo @kaikreuzer