Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up removed links in GenericItemChannelLinkProvider #4326

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jul 22, 2024

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner July 22, 2024 14:58
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-2-updating-an-items-file-does-not-remove-links-to-channels/157331/3

@jimtng jimtng marked this pull request as draft July 22, 2024 15:02
@jimtng jimtng force-pushed the generic-item-links-cleanup branch from 8d3c0dc to fa01121 Compare July 23, 2024 02:26
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the generic-item-links-cleanup branch from d2637a1 to ad2ba02 Compare July 23, 2024 02:32
@jimtng jimtng marked this pull request as ready for review July 23, 2024 03:06
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K merged commit cb19001 into openhab:main Jul 27, 2024
4 checks passed
@J-N-K J-N-K added this to the 4.3 milestone Jul 27, 2024
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jul 27, 2024
@jimtng jimtng deleted the generic-item-links-cleanup branch July 27, 2024 16:47
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh4-2-upgrade-even-though-everything-runs-fine-there-are-125-orphan-links/157464/4

@lolodomo
Copy link
Contributor

lolodomo commented Aug 4, 2024

@openhab/core-maintainers : probably a fix to backport to 4.2.x ?

kaikreuzer pushed a commit to kaikreuzer/openhab-core that referenced this pull request Aug 4, 2024
* Clean up removed links in GenericItemChannelLinkProvider
* defer processing until stopConfigurationUpdate is called

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@kaikreuzer
Copy link
Member

Cherry-picked to 4.2.x.

@kaikreuzer kaikreuzer added the patch A PR that has been cherry-picked to a patch release branch label Aug 4, 2024
wborn pushed a commit that referenced this pull request Sep 7, 2024
* Clean up removed links in GenericItemChannelLinkProvider
* defer processing until stopConfigurationUpdate is called

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@wborn
Copy link
Member

wborn commented Sep 7, 2024

It was cherry-picked to your own fork so I've cherry-picked it to the OH repo as well now. 😉
See: openhab/openhab-webui#2746 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants