Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/sitemaps.md: emphasize period= is mandatory parameter in Chart #2091

Merged

Conversation

dilyanpalauzov
Copy link
Contributor

I just struggled to configure a Chart in sitemap, until I figured out that period= must be set.

This changeset emphasizes that period= is mandatory. It also sets item= in Text and Chart as mandatory, and item= in Group as optional, as this is what makes sense for me.

@netlify
Copy link

netlify bot commented Jun 17, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit ae74a87
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/6490b5d1b04ecd0008f0e001
😎 Deploy Preview https://deploy-preview-2091--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dilyanpalauzov dilyanpalauzov changed the title ui/sitemaps.md: emphasize mandatory and optional parameters ui/sitemaps.md: emphasize period= is mandatory parameter in Chart Jun 19, 2023
@dilyanpalauzov
Copy link
Contributor Author

For Group and Text I reverted the initial changes, as the system does not accept Group without item=, but accepts Text without item=

Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍🏼

@Confectrician Confectrician added this to the 4.0 milestone Jul 1, 2023
@Confectrician Confectrician merged commit 098ddb5 into openhab:main Jul 1, 2023
@dilyanpalauzov dilyanpalauzov deleted the sitemaps_mandatory_parameters branch July 1, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants