Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockly uom fix pic #2107

Merged
merged 8 commits into from
Nov 18, 2023
Merged

Conversation

stefan-hoehn
Copy link
Contributor

fixes #2104

@netlify
Copy link

netlify bot commented Jul 27, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 15560f8
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/64c2979107d2b30008d530c8
😎 Deploy Preview https://deploy-preview-2107--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefan-hoehn stefan-hoehn added this to the 4.0 milestone Jul 27, 2023
@Confectrician
Copy link
Contributor

@stefan-hoehn you added this to 4.0 milestone.
Is this on purpose? Do you want this to be als ported to the stable docs?

@stefan-hoehn
Copy link
Contributor Author

I was actually thinking if 4.0.1 would be related to 4.0 or 4.1 and I honestly didn't know. It belongs to 4.0.1, so does that mean 4.1 already?

@Confectrician
Copy link
Contributor

It is not really about which milestone we choose, i would need to know the answer of my question to give some proper information:

Do you want this to be als ported to the stable docs?

So do you want it to be ported?

@stefan-hoehn stefan-hoehn modified the milestones: 4.0, 4.1 Aug 4, 2023
@stefan-hoehn
Copy link
Contributor Author

I should have been more clear. No, it shouldn't have been backported, just to be long the next minor release 4.0.2 but I am fine with 4.1 as well.

@stefan-hoehn stefan-hoehn merged commit 2de9c53 into openhab:main Nov 18, 2023
4 checks passed
@stefan-hoehn stefan-hoehn deleted the blockly_uom_fix_pic branch November 18, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blockly Unit of Measurement
2 participants