Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework7 icons now supported by Basic UI #2118

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Aug 9, 2023

Signed-off-by: Laurent Garnier lg.hc@free.fr

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 9, 2023

To be merged when the following PR is merged:
openhab/openhab-webui#2013

@netlify
Copy link

netlify bot commented Aug 9, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit e655ede
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/64d40122f81d400008230ff6
😎 Deploy Preview https://deploy-preview-2118--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lolodomo
Copy link
Contributor Author

Change merged for Basic UI. So this PR can now be merged.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Aug 21, 2023
@stefan-hoehn stefan-hoehn merged commit 0d67c5c into openhab:main Aug 21, 2023
4 checks passed
@lolodomo lolodomo deleted the basicui_f7 branch August 21, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants