Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Explain implicit profiles #2141

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Conversation

andrewfg
Copy link
Contributor

This PR adds an explanation of how the framework uses implicit profiles for items where no profile is explicitly defined.

See openhab/openhab-addons#15656 (comment)

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Copy link
Contributor Author

@lolodomo for info..

@netlify
Copy link

netlify bot commented Oct 15, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 5986c9b
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/655ca1ab7ef8bf0007e39231
😎 Deploy Preview https://deploy-preview-2141--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good addition to the docs here. See my small recommendation.

configuration/items.md Outdated Show resolved Hide resolved
@lolodomo
Copy link
Contributor

lolodomo commented Dec 16, 2023

There is another page where profiles are defined and this page is not clear about defaults.
I have to find this page...

Edit: it is in fact in the same page ! So maybe you could also fix a little the "Profile" section in this page ?

@stefan-hoehn
Copy link
Contributor

@lolodomo Should I wait to merge until your request has been done by @andrewfg ?

@lolodomo
Copy link
Contributor

@lolodomo Should I wait to merge until your request has been done by @andrewfg ?

In case @andrewfg can handle it before OH 4.1 is released, yes please.

@andrewfg
Copy link
Contributor Author

There is another page where profiles are defined and this page is not clear about defaults.

@lolodomo my new 'Implicit Profiles' chapter is a direct sub chapter of the 'Profiles' chapter so I am not clear on what extra you want me to add?

@lolodomo
Copy link
Contributor

lolodomo commented Dec 17, 2023

@lolodomo my new 'Implicit Profiles' chapter is a direct sub chapter of the 'Profiles' chapter

Sorry, I did not realize that.
So it should be fine.
Please ignore my previous comment.

@stefan-hoehn : feel free to merge.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Andrew, for the contribution.
Looks good to me as well.

@stefan-hoehn stefan-hoehn merged commit b3e070a into openhab:main Dec 17, 2023
5 checks passed
@andrewfg andrewfg deleted the profiles branch August 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants