-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra fields for addon discovery in addon.xml #2150
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
@andrewfg Did you see the failing markdown errors? |
I did now. There seems to be also some errors not related to this PR.. |
Yep, I fixed the others but it seems unfortunately you need to rebase before it would work. |
I will do that. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
46cd471
to
4cf8758
Compare
@andrewfg I was able to rebase the branch, so it based on the latest version of the files that prevented you to build. Please pull your repo accordingly before you continue. |
…/openhab-docs into addon-suggestion-finder
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@stefan-hoehn this PR is now ready to go. @stefan-hoehn or @kaikreuzer can you kindly also update the xsd schemas on the web site? |
@andrewfg Already done, see openhab/openhab-core#3865 (comment). |
@stefan-hoehn do I need to do anything more on this PR to ensure it gets merged? |
LGTM, merging |
Documentation of new fields in
addon.xml
In OpenHAB core there is a PR #3865 which adds extra fields to the addon.xml file so that addons may be discovered during the initial setup of OH and thus be suggested to be installed during setup. This PR is the documentation for the additional fields.
Publish updated XML schema with new fields on OpenHAB Web Server
The extra fields introduced in PR #3865 are self documented in the XML schema file
addon-1.0.0.xsd
in 'org.openhab.core.addon', so the new version of this file needs to be manually copied to the OH web server as well.Signed-off-by: Andrew Fiddian-Green software@whitebear.ch