Add logo for ecowatt binding #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
logo_ecowatt
branch
from
06b1527
to
94e18c7
Compare
|
Unfortunately, the logo is really top because the "watt" is not seen due to white over white.
|
|
Good catch, I will have an eye on that in the future. Will you provide an update? What you could do is something like the following: 
|
|
I took the icon from the official website. |
|
Or why not using this one? 
Update: I found a squared one as well (though I like the rounded one better)
|
|
Yes, looks better. |
|
I am submitting a new PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier lg.hc@free.fr