Interactive SVG docs: review comments after merge #2405
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
stefan-hoehn
changed the title
florian-h05
reviewed
Nov 16, 2024
ui/layout-pages-fixed.md
Outdated
| @@ -181,7 +181,7 @@ Additionally, the following settings are important: | |||
| By default, this is switched off and therefore needs to be enabled. | |||
|
|
|||
| - **Embed SVG Flashing in Run-Mode**: It is possible within the editor to flash the elements of the SVG image that have been previously marked as interactive through the attribute 'openhab' (see below). | |||
There was a problem hiding this comment.
"It is ... (see below)." in this line can be removed and only "This setting ... over them." be used.
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
florian-h05
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feedback from @florian-h05 regarding #2398