Support iconify icons #724
Conversation
| return Endpoint( | ||
| baseURL: "https://api.iconify.design/", | ||
| path: "/\(set)/\(icon).svg", | ||
| queryItems: [URLQueryItem(name: "height", value: "64")] |
There was a problem hiding this comment.
Without this, SVGKit gives this error: https://github.com/SVGKit/SVGKit/blob/96c330df9627b26c1d3a3eb48a84b4eb5d21d7b3/Source/DOM%20classes/Core%20DOM/CSSPrimitiveValue.m#L150 and we just display an exclamation icon. I'm not sure if this is actually used by SVGKit, but 64 seems to be the size of the SVG icons from openHAB.
Closes openhab#716 Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
|
@digitaldan @timbms any chance you could take a look at this? |
|
Hey @ccutrer , yeah i will take a look this weekend, been a bit busy this month. Its also time to get a actual release pushed, so will schedule that after this gets merged. Thanks! |
|
Great. Please do not forget to update the table in the documentation showing what icon source is supported by each UI. |
|
@digitaldan: are you waiting on anything before doing the official release? |
|
No, just free time ;-) I'll look at getting a release ready this weekend. |
See openhab/openhab-ios#724 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
See openhab/openhab-ios#724 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
See openhab/openhab-ios#724 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
@digitaldan : any chance we could get a new release? or at least a new beta? The old beta expired, and can't be launched or joined anymore |
|
I just kicked of a test flight build. Unfortunately i never was able to get the production Fastlane build to run locally which i need to generate all the required screenshots for the the Apple store (there's a lot of them) . Its the only thing i think keeping us from pushing out a new build. Maybe @timbms or @weakfl could help with that? I spent a day trying to get it working before getting distracted on other projects. |
|
Hello All. Was a new version of the IOS application ever published? The issue with iconify in the sitemap remains without an IOS app update. |
Closes #716