Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MainUI] Knob or Gauge widgets overriding the Close button #536

Closed
lolodomo opened this issue Nov 18, 2020 · 2 comments · Fixed by #540
Closed

[MainUI] Knob or Gauge widgets overriding the Close button #536

lolodomo opened this issue Nov 18, 2020 · 2 comments · Fixed by #540
Labels
bug Something isn't working main ui Main UI

Comments

@lolodomo
Copy link
Contributor

The problem

After selecting a knob or a gauge for a number item, I can't click on the Close button at the bottom of the window.

image

For the Know, there is no visual overriding but when you click on the Close button, it just selects the "40" value.

image

For the Gauge, there is a clear visual overriding.

Expected behavior

Keep the necessary space for the selected widget and allow to push the button "Close".

Addtionaly, I am asking myself if the gauge or knob should not be more at the right rather than at the center.

Your environment

Firefox on Windows 10 or Google Chrome on Android smartphone.

Additional information

This looks promising to be able to choose these kinds of widgets.

@lolodomo lolodomo added bug Something isn't working main ui Main UI labels Nov 18, 2020
@lolodomo
Copy link
Contributor Author

image

@ghys
Copy link
Member

ghys commented Nov 18, 2020 via email

ghys added a commit to ghys/openhab-webui that referenced this issue Nov 19, 2020
Disallow standalone widgets to be selected for list items (close openhab#536).

Allow slight alterations to the default widgets suggested by the system
without reconfiguring it completely: if the metadata value is blank,
assume the default system-suggested widget is to be used and merge the
config found in the metadata.
Closes openhab#534 (since now only the iconUseState option has to be set to
enable dynamic icons for Number items and similar).

Change the metadata namespace selection menu to only display the metadata
which is set in the metadata menu, and use an action sheet to add more.
This also paves the way for user-defined namespaces.

Move the metadata order out of the item edition card in the Model page,
into its own section.

Add metadata editor for the expire namespace
(openhab/openhab-core#1620).

Reorder the sections of the item details page in a more logical manner
(semantic classification below the tags that define it).

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys closed this as completed in #540 Nov 19, 2020
ghys added a commit that referenced this issue Nov 19, 2020
Disallow standalone widgets to be selected for list items (close #536).

Allow slight alterations to the default widgets suggested by the system
without reconfiguring it completely: if the metadata value is blank,
assume the default system-suggested widget is to be used and merge the
config found in the metadata.
Closes #534 (since now only the iconUseState option has to be set to
enable dynamic icons for Number items and similar).

Change the metadata namespace selection menu to only display the metadata
which is set in the metadata menu, and use an action sheet to add more.
This also paves the way for user-defined namespaces.

Move the metadata order out of the item edition card in the Model page,
into its own section.

Add metadata editor for the expire namespace
(openhab/openhab-core#1620).

Reorder the sections of the item details page in a more logical manner
(semantic classification below the tags that define it).

Signed-off-by: Yannick Schaus <github@schaus.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants