[basicui] Fix setpoint/slider widgets when %unit% is used in state pattern #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
changed the title
pattern This is the same fix as openhab#1611 but for OH 4.0 main branch. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
getUnitForWidget_OH4
branch
from
8456e75
to
da9f28e
Compare
|
This PR will have to be cherry picked in branch 3.4.x as it fixed a critical issue introduced by a change in the core framework. |
lolodomo
added
the
patch
|
@kaikreuzer @ghys : please review this PR, we need it for the 3.4 patch (I added the tag). |
kaikreuzer
changed the title
kaikreuzer
approved these changes
Dec 31, 2022
kaikreuzer
pushed a commit
that referenced
this pull request
Dec 31, 2022
) This is the same fix as #1611 but for OH 4.0 main branch. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
Thank you. I have cherry-picked the change onto the |
4 tasks
crnjan
pushed a commit
to crnjan/openhab-webui
that referenced
this pull request
Jan 17, 2023
…enhab#1612) This is the same fix as openhab#1611 but for OH 4.0 main branch. Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same fix as #1611 but for OH 4.0 main branch.
Signed-off-by: Laurent Garnier lg.hc@free.fr