Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap editor: fix staticIcon parameter #2141

Closed
wants to merge 1 commit into from

Conversation

mherwege
Copy link
Contributor

One missing blank in the lexer made the functionality fail, but the test still succeed.
Corrected the blank, and then also had to correct the DSL generator.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner October 18, 2023 10:17
@relativeci
Copy link

relativeci bot commented Oct 18, 2023

Job #1213: Bundle Size — 15.79MiB (+0.2%).

9e6f88d(current) vs b7270d2 main#1158(baseline)

Warning

Bundle contains 16 duplicate packages – View duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1213
     Baseline
Job #1158
Regression  Initial JS 1.85MiB(+10.94%) 1.67MiB
Regression  Initial CSS 608.95KiB(+0.01%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 2987(+75.71%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1213
     Baseline
Job #1158
Regression  JS 9.28MiB (+0.24%) 9.25MiB
Regression  Other 4.74MiB (+0.19%) 4.73MiB
Regression  CSS 860.19KiB (+0.08%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1213 reportView mherwege:staticIcon-fix branch activity

@mherwege
Copy link
Contributor Author

Included in #2145

@mherwege mherwege closed this Oct 20, 2023
@mherwege mherwege deleted the staticIcon-fix branch October 20, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant