Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap Editor: Extend chart period config for ISO8601 #2186

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Nov 25, 2023

Adjust sitemap configuration in main UI for recent changes in sitemap chart period configuration, see openhab/openhab-core#3863.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner November 25, 2023 21:26
Copy link

relativeci bot commented Nov 25, 2023

Job #1277: Bundle Size — 15.81MiB (+0.3%).

3056db5(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1277
     Baseline
Job #1158
Regression  Initial JS 1.89MiB(+13.12%) 1.67MiB
Regression  Initial CSS 609.63KiB(+0.12%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3027(+78.06%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1277
     Baseline
Job #1158
Regression  JS 9.29MiB (+0.33%) 9.25MiB
Regression  Other 4.74MiB (+0.33%) 4.73MiB
Regression  CSS 860.87KiB (+0.16%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1277 reportView mherwege:sitemap_period_config branch activity

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Copy link
Contributor Author

@lolodomo FYI

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading openhab/openhab-docs#2158, it seems that 2h, 5D etc. should still be supported, but the sitemap editor warns when trying to use them. Can you please fix that?

Also please have a look at my comment below, and consider to use the validate property of the input (see https://framework7.io/vue/inputs#input-properties) to let the user know his input is invalid while typing.

@mherwege
Copy link
Contributor Author

mherwege commented Nov 26, 2023

Reading openhab/openhab-docs#2158, it seems that 2h, 5D etc. should still be supported, but the sitemap editor warns when trying to use them. Can you please fix that?

That should still work, and it did in my testing. There is even a testcase covering it (for 4h). It may have been the second (missing) commit.
While it will work, I opted for a placeholder for the general format.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Copy link
Contributor Author

Also please have a look at my comment below, and consider to use the validate property of the input (see https://framework7.io/vue/inputs#input-properties) to let the user know his input is invalid while typing.

The validate property is now used. I still keep the separate validation as well as the a wrong value could be provided through the editor.

@mherwege
Copy link
Contributor Author

@florian-h05 Thank you for your feedback. I believe I responded to your remarks.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

FYI I have removed validate-on-blur.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Nov 26, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Nov 26, 2023
@florian-h05 florian-h05 merged commit 6dfed00 into openhab:main Nov 26, 2023
6 checks passed
@mherwege
Copy link
Contributor Author

FYI I have removed validate-on-blur.

Fine with me, but I explicitely disabled it because it just gives an error already on typing the first character, even when it is part of a perfectly valid period definition. I didn't like that, especially because there are many valid combinations and checking the regex only makes sense when the input is complete. With validate-on-blur it only checks at the end.

@mherwege mherwege deleted the sitemap_period_config branch November 27, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants