Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ${enable_kargs} check in example recipe script #147

Closed
koomie opened this issue Jan 14, 2016 · 1 comment
Closed

Improve ${enable_kargs} check in example recipe script #147

koomie opened this issue Jan 14, 2016 · 1 comment
Assignees
@koomie
Labels
documentation
Milestone
1.1

Comments

@koomie
Copy link
Contributor

koomie commented Jan 14, 2016

No description provided.

@koomie koomie added this to the 1.1 milestone Jan 14, 2016
koomie added a commit that referenced this issue Apr 7, 2016
@koomie
prefer [[ ]] syntax for enable_var checks (#147)
7e169ad
koomie added a commit that referenced this issue Apr 7, 2016
@koomie
prefer [[ ]] syntax for enable_var checks (#147)
7aa43f2
koomie added a commit that referenced this issue Apr 7, 2016
@koomie
prefer [[ ]] syntax for enable_var checks in sles recipe (#147)
a81230c
@koomie koomie self-assigned this Apr 8, 2016
@koomie
Copy link
Contributor Author

koomie commented Apr 8, 2016

I dug into this a bit more and the issue folks likely observed is a syntax error if the enable_kargs variable was not set. These enable_* variables do get assigned in the companion input file, but if someone was creating their own input file, it is certainly possible to neglect some of them and see syntax errors running recipe.sh. Adopting the Bash [[ ]] construct provides the desired behavior in cases where these enable_ variables are not initialized and the scripts were updated accordingly.

@koomie koomie closed this as completed Apr 8, 2016
@koomie koomie removed the component label Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koomie koomie

Labels
documentation
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@koomie