Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lmod to 8.7.32 #1906

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Update lmod to 8.7.32 #1906

merged 2 commits into from
Nov 3, 2023

Conversation

adrianreber
Copy link
Member

See: #1905

Signed-off-by: Adrian Reber <areber@redhat.com>
Should fix errors seen with the Intel compiler modulefiles.

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber adrianreber merged commit 54a8a14 into openhpc:2.x Nov 3, 2023
11 checks passed
@adrianreber adrianreber deleted the 2023-11-03-lmod branch November 3, 2023 08:22
@@ -97,7 +97,7 @@ make DESTDIR=$RPM_BUILD_ROOT install
########################################################################

# NOOP if running under known resource manager
if [ ! -z "\$SLURM_NODELIST" ] | [ ! -z "\$PBS_NODEFILE" ]; then
if [ -n "\$SLURM_NODELIST" ] || [ -n "\$PBS_NODEFILE" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't || be && ? I.e. if neither is defined then return early.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, good question. Let me take a look.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested a couple of combinations and it works as expected. The goal is, if one is set it should return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants