Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerman: Remove the spec and the documentation for powerman #2035

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Oct 1, 2024

No description provided.

Copy link

github-actions bot commented Oct 1, 2024

Test Results

24 files  + 6  24 suites  +6   27s ⏱️ -2s
63 tests +10  52 ✅ +3  11 💤 + 7  0 ❌ ±0 
86 runs  +20  68 ✅ +6  18 💤 +14  0 ❌ ±0 

Results for commit 373d462. ± Comparison against base commit d928d03.

♻️ This comment has been updated with latest results.

@adrianreber
Copy link
Member

I don't think we ship that for a long time. I do not see it mentioned in the OBS configuration for 2.x and 3.x. Also for 1.3.x and even older it was never part of the documentation.

The right thing would be to just remove it. Do you want to remove the SPEC file and from the documentation?

@martin-g
Copy link
Contributor Author

martin-g commented Oct 1, 2024

I'll remove it!

@martin-g martin-g changed the title powerman: Update to 2.4.4 powerman: Remove the spec and the documentation for powerman Oct 2, 2024
@martin-g
Copy link
Contributor Author

martin-g commented Oct 2, 2024

It seems to be used by conman -

SERVER resetcmd="powerman -0 %N; sleep 3; powerman -1 %N"

I'd expect a Requires: for it.

@martin-g martin-g force-pushed the powerman-2.4.4 branch 2 times, most recently from 88bd1ba to 96c0739 Compare October 2, 2024 06:43
@adrianreber
Copy link
Member

It seems to be used by conman -

SERVER resetcmd="powerman -0 %N; sleep 3; powerman -1 %N"

I'd expect a Requires: for it.

It is strange, indeed. But powerman was never built. I also saw that line and was confused.

@adrianreber
Copy link
Member

We probably should remove the line. It never worked anyway.

@adrianreber
Copy link
Member

adrianreber commented Oct 2, 2024

The skip command in those bats tests does not seem to work. Strange. Seems unrelated to this change, however.

Maybe the skip command does not work outside of @test.

@martin-g martin-g force-pushed the powerman-2.4.4 branch 4 times, most recently from 57b27f1 to 9b9f25a Compare October 2, 2024 11:26
@adrianreber
Copy link
Member

Almost ready to be merged. Could you remove your debug statements from the first commit? Currently you have it in the second commit which means there are some unnecessary code changes in this PR which I would prefer to not have in the repository.

It was not used since a long time.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Contributor Author

martin-g commented Oct 4, 2024

Could you remove your debug statements from the first commit?

I didn't know how to do it until now! Thanks for pushing me over my limits ! :-)

@adrianreber
Copy link
Member

Could you remove your debug statements from the first commit?

I didn't know how to do it until now! Thanks for pushing me over my limits ! :-)

Glad I could help! 😉

@adrianreber adrianreber merged commit 611b01f into openhpc:3.x Oct 11, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants