Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdf5: Update to 1.14.5 #2041

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

hdf5: Update to 1.14.5 #2041

wants to merge 2 commits into from

Conversation

martin-g
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Oct 10, 2024

Test Results

0 files   - 18  0 suites   - 18   0s ⏱️ -25s
0 tests  - 53  0 ✅  - 49  0 💤  - 4  0 ❌ ±0 
0 runs   - 66  0 ✅  - 62  0 💤  - 4  0 ❌ ±0 

Results for commit d540a10. ± Comparison against base commit 095a8f3.

♻️ This comment has been updated with latest results.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Contributor Author

The error in the tests is not very clear to me...

@adrianreber
Copy link
Member

I was running it locally in a container and I saw:

ohpc@0f4ae85d3bac:/share/ohpc/tests/libs/hdf5/test-env-variables-new/C/H5T> ./test.sh
Testing C/H5T/h5ex_t_int...  Passed
Testing C/H5T/h5ex_t_intatt...  Passed
Testing C/H5T/h5ex_t_float...  Passed
Testing C/H5T/h5ex_t_floatatt...  Passed
Testing C/H5T/h5ex_t_enum...  Passed
Testing C/H5T/h5ex_t_enumatt...  Passed
Testing C/H5T/h5ex_t_bit...  Passed
Testing C/H5T/h5ex_t_bitatt...  Passed
Testing C/H5T/h5ex_t_opaque...  Passed
Testing C/H5T/h5ex_t_opaqueatt...  Passed
Testing C/H5T/h5ex_t_array...  Passed
Testing C/H5T/h5ex_t_arrayatt...  Passed
Testing C/H5T/h5ex_t_vlen...  FAILED!
Testing C/H5T/h5ex_t_vlenatt...  FAILED!
Testing C/H5T/h5ex_t_string...  Passed
Testing C/H5T/h5ex_t_stringatt...  Passed
Testing C/H5T/h5ex_t_vlstring...  Passed
Testing C/H5T/h5ex_t_vlstringatt...  Passed
Testing C/H5T/h5ex_t_cmpd...  Passed
Testing C/H5T/h5ex_t_cmpdatt...  Passed
Testing C/H5T/h5ex_t_commit...  Passed
Testing C/H5T/h5ex_t_objref...  Passed
Testing C/H5T/h5ex_t_objrefatt...  Passed
Testing C/H5T/h5ex_t_regref...  Passed
Testing C/H5T/h5ex_t_regrefatt...  Passed
Testing C/H5T/h5ex_t_cpxcmpd...  Passed
Testing C/H5T/h5ex_t_cpxcmpdatt...  Passed
Testing C/H5T/h5ex_t_convert...  Passed
2 tests failed in C/H5T/

The test compares the output of the tools with some predefined output. Not sure where the predefined output comes from. Maybe that needs to be updated.

@martin-g
Copy link
Contributor Author

Thanks!
The comparison happens here but I cannot figure out where the echoed output goes to. It seems it is not written into a .log file and that's why we cannot see the diff.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants