Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not used PULP DIV/SQRT still mentioned in User Manual v1.8.3 #1027

Open
pascalgouedo opened this issue Jul 16, 2024 · 0 comments
Open

Not used PULP DIV/SQRT still mentioned in User Manual v1.8.3 #1027

pascalgouedo opened this issue Jul 16, 2024 · 0 comments
Labels
Component:Doc For issues in the Documentation (e.g. for README.md files) Type:Enhancement For feature requests and enhancements

Comments

@pascalgouedo
Copy link

Component

Component:Doc

Description

Even if it has been removed from manifest list, old PULP Floating-Point DIV/SQRT unit is still mentioned in section 3.5 Synthesis guidelines.
And the sentence contains old and new information all together.

The top level module is called cv32e40p_top and includes both the core and the FPU. All the core files are in rtl and rtl/include folders (all synthesizable) while all the FPU files are in rtl/vendor/pulp_platform_common_cells, rtl/vendor/pulp_platform_fpnew and rtl/vendor/pulp_platform_fpu_div_sqrt. .. while all the FPU files are in rtl/vendor/pulp_platform_common_cells, rtl/vendor/pulp_platform_fpnew and rtl/vendor/opene906.

Above sentence should be changed to

The top level module is called cv32e40p_top and includes both the core and the FPU. All the core files are in rtl and rtl/include folders (all synthesizable) while all the FPU files are in rtl/vendor/pulp_platform_common_cells, rtl/vendor/pulp_platform_fpnew and rtl/vendor/opene906.

But the mentioned cv32e40p_fpu_manifest.flist file content is correct.

@pascalgouedo pascalgouedo added Type:Enhancement For feature requests and enhancements Component:Doc For issues in the Documentation (e.g. for README.md files) labels Jul 16, 2024
pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Jul 19, 2024
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
davideschiavone added a commit that referenced this issue Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Doc For issues in the Documentation (e.g. for README.md files) Type:Enhancement For feature requests and enhancements
Projects
None yet
Development

No branches or pull requests

1 participant