Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Xpulp memory instructions set extra memory access #731

Closed
salaheddinhetalani opened this issue Sep 27, 2022 · 1 comment
Closed
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) PARAM:FPU Issue depends on the FPU parameter PARAM:PULP_XPULP Issue depends on the PULP_XPULP parameter Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system

Comments

@salaheddinhetalani
Copy link

Issue Description

Custom load or store I or RI instructions set extra memory access in case they are preceded by a multicycle F instruction.

Component

Component:RTL

RISC-V Specification

The Zfinx extension adds all of the instructions that the F extension adds, except for the transfer instructions FLW, FSW, FMV.W.X, FMV.X.W, C.FLW[SP], and C.FSW[SP].

The Zfinx variants of these F-extension instructions have the same semantics, except that whenever such an instruction would have accessed an f register, it instead accesses the x register with the same number.

Steps to Reproduce

As shown below, the following sequence of instructions happens:

fdiv.s x15, x6, x24, RDN -> cv.lw.i x11, -1058(x23!)

The instruction cv.lw.i is decoded at t##0 and executed updating the integer register file at t##1 writing x23 and at t##3 writing x11 after reading the loaded data from memory. The load instruction accesses the memory at t##1 setting the memory request. The request is granted at t##2 and the response from memory is valid at t##3. What is odd is seeing unexpected new memory access set again at t##3. Which is as well true for the additional write of x11 at t##5.

Bug_27

Top Level Parameters

cv32e40p_wrapper #(
    .PULP_XPULP       (1),
    .PULP_CLUSTER     (1),
    .FPU              (1),
    .PULP_ZFINX       (1),
    .NUM_MHPMCOUNTERS (1)
)

Git Hash: TBU
Flist: cv32e40p_fpu_manifest.flist
VCD: bug_27.vcd


Product: OneSpin 360 DV-Verify
App: Processor Verification App
Tool's version: 2022.3_1

@pascalgouedo pascalgouedo added Component:RTL For issues in the RTL (e.g. for files in the rtl directory) PARAM:FPU Issue depends on the FPU parameter PARAM:PULP_XPULP Issue depends on the PULP_XPULP parameter labels Nov 9, 2022
@salaheddinhetalani salaheddinhetalani changed the title Custom memory Xpulp instructions set extra memory access Custom Xpulp memory instructions set extra memory access Nov 28, 2022
@pascalgouedo pascalgouedo added the Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system label Mar 23, 2023
pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Aug 16, 2023
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Aug 16, 2023
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Aug 21, 2023
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Aug 22, 2023
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Aug 29, 2023
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Oct 2, 2023
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
@pascalgouedo
Copy link

Resolved with PR #860

pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Oct 10, 2023
…hwgroup#731 and openhwgroup#742 bugs correction.

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
davideschiavone pushed a commit that referenced this issue Oct 10, 2023
* Corrected table name

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>

* Updated SIMD cv.add/cv.sub

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>

* Updated Pipeline details after #723, #652, #731 and #742 bugs correction.

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>

* Formality script improvment

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>

---------

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
@pascalgouedo pascalgouedo added the Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) PARAM:FPU Issue depends on the FPU parameter PARAM:PULP_XPULP Issue depends on the PULP_XPULP parameter Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system
Projects
None yet
Development

No branches or pull requests

2 participants