Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing case default #959

Closed
pascalgouedo opened this issue Mar 14, 2024 · 1 comment
Closed

Missing case default #959

pascalgouedo opened this issue Mar 14, 2024 · 1 comment
Assignees
@pascalgouedo
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation Type:Enhancement For feature requests and enhancements

Comments

@pascalgouedo
Copy link

Issue Description

It is generally a good practice/coding rule to have a default for every case.
Moreover missing default is reported as a hole by coverage tools and should be analysed and waived again and again.

In cv32e40p_load_store_unit.sv, this occurs 4 times on lines 123, 131, 143 and 156.

Component

Component:RTL

Steps to Reproduce

RTL code review
@pascalgouedo pascalgouedo added Type:Enhancement For feature requests and enhancements Component:RTL For issues in the RTL (e.g. for files in the rtl directory) labels Mar 14, 2024
@pascalgouedo pascalgouedo self-assigned this Mar 14, 2024
pascalgouedo pushed a commit to pascalgouedo/cv32e40p that referenced this issue Mar 14, 2024
Issue openhwgroup#959 correction.
6ac2316 
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
@pascalgouedo
Copy link
Author

pascalgouedo commented Mar 18, 2024 •
edited
Loading

Corrected with PR #961

@pascalgouedo pascalgouedo added the Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalgouedo pascalgouedo

Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation Type:Enhancement For feature requests and enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pascalgouedo