Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Make pipeline stall on all CSR accesses (#169) #181

Closed
wants to merge 1 commit into from
Closed

Conversation

stmach
Copy link
Contributor

@stmach stmach commented Oct 8, 2019

Fixes bugs where changed CSR state is not visible to following instructions such as when changing the FP status CSR.
Fixes #169.

Fixes bugs where changed CSR state is not visible to following instructions such as when changing the FP status CSR.
@stmach stmach marked this pull request as ready for review October 8, 2019 09:53
@stmach stmach requested a review from davideschiavone October 8, 2019 09:53
@davideschiavone
Copy link
Contributor

Shall we merge @stmach ?

@stmach
Copy link
Contributor Author

stmach commented Nov 13, 2019

As in the current version of the core state-modifying CSRs have to be explicitly black-listed, this fix is kind of a "shotgun" approach to missing some registers - and hence loses performance.
A cleaner (and safer) approach would be to stall it by default (like this PR) but have a white-list of safe CSRs that don't need to flush the pipeline. We can merge this and think of opening a new issue for this as performance improvement.

Btw, the signal name csr_status_o that causes the pipeline to be flushed on CSR access is a bit misleading, consider refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal Instruction Exception not Raised - Dynamic Rounding Mode
2 participants