Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom browser support #201

Merged
merged 1 commit into from
Feb 10, 2018

Conversation

WilliamDenniss
Copy link
Member

@codecov-io
Copy link

codecov-io commented Feb 9, 2018

Codecov Report

Merging #201 into master will decrease coverage by 1.51%.
The diff coverage is 8.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   68.03%   66.51%   -1.52%     
==========================================
  Files          40       41       +1     
  Lines        3898     3993      +95     
  Branches       73       73              
==========================================
+ Hits         2652     2656       +4     
- Misses       1244     1335      +91     
  Partials        2        2
Impacted Files Coverage Δ
...e/iOS/OIDAuthorizationUICoordinatorCustomBrowser.m 0% <0%> (ø)
Source/OIDURLQueryComponent.m 91.96% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d6aabe...376cbe0. Read the comment docs.

@WilliamDenniss WilliamDenniss force-pushed the custombrowser branch 5 times, most recently from 4ab7ce2 to b0e4a30 Compare February 9, 2018 23:26
- An UICoordinator for iOS to support auth with a custom iOS browser like Chrome or Firefox.
- Implements openid#200.
@WilliamDenniss WilliamDenniss merged commit 135f99d into openid:master Feb 10, 2018
@WilliamDenniss WilliamDenniss deleted the custombrowser branch July 13, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants