Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UICoordinator refactor #212

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Conversation

WilliamDenniss
Copy link
Member

Following on from #196.

Lucas Farris and others added 2 commits February 12, 2018 20:25
…ed for more than just authorization purposes. Relates to issue openid#195
Drop the "UICoordinator". Just "OIDExternalUserAgent". It's cleaner.
@codecov-io
Copy link

codecov-io commented Mar 7, 2018

Codecov Report

Merging #212 into master will increase coverage by 0.51%.
The diff coverage is 12.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   66.51%   67.03%   +0.51%     
==========================================
  Files          41       41              
  Lines        3993     4004      +11     
  Branches       73       73              
==========================================
+ Hits         2656     2684      +28     
+ Misses       1335     1318      -17     
  Partials        2        2
Impacted Files Coverage Δ
Source/iOS/OIDAuthorizationService+IOS.m 0% <0%> (ø) ⬆️
Source/macOS/OIDAuthState+Mac.m 0% <0%> (ø) ⬆️
Source/macOS/OIDAuthorizationService+Mac.m 0% <0%> (ø) ⬆️
Source/OIDAuthorizationService.m 16.83% <0%> (-0.12%) ⬇️
Source/macOS/OIDRedirectHTTPHandler.m 0% <0%> (ø) ⬆️
Source/iOS/OIDAuthState+IOS.m 0% <0%> (ø) ⬆️
Source/macOS/OIDExternalUserAgentMac.m 0% <0%> (ø)
Source/OIDAuthState.m 42.27% <0%> (ø) ⬆️
Source/iOS/OIDExternalUserAgentIOS.m 0% <0%> (ø)
Source/iOS/OIDExternalUserAgentIOSCustomBrowser.m 0% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d321b8...cb5670e. Read the comment docs.

@WilliamDenniss WilliamDenniss changed the title ExternalUserAgent refector ExternalUserAgent refactor Mar 8, 2018
@WilliamDenniss WilliamDenniss changed the title ExternalUserAgent refactor UICoordinator generalization Mar 8, 2018
@WilliamDenniss WilliamDenniss changed the title UICoordinator generalization UICoordinator refactor Mar 8, 2018
@WilliamDenniss WilliamDenniss merged commit 776c5fd into openid:master Mar 8, 2018
WilliamDenniss added a commit that referenced this pull request Mar 8, 2018
@WilliamDenniss WilliamDenniss deleted the pr196 branch July 13, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants