This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dennisreimann sorry for causing such a mess, should have tested that properly earlier ...
Turns out our non-json detector had a bug and did not catch the nested current/services in the serialized hash, fixing this would mean iterating over current/services and serializing+deserializing every element, which is just a mess (tried it, makes the code grow about 15 loc + ugly)
also FYI I realized that json session is not going to happen since rails flash uses an array of symbols internally which cannot be jsonified, so I'm killing that project :)