Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

revert serializer changes #73

Merged
merged 2 commits into from
Jan 29, 2014
Merged

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jan 29, 2014

@dennisreimann sorry for causing such a mess, should have tested that properly earlier ...
Turns out our non-json detector had a bug and did not catch the nested current/services in the serialized hash, fixing this would mean iterating over current/services and serializing+deserializing every element, which is just a mess (tried it, makes the code grow about 15 loc + ugly)

also FYI I realized that json session is not going to happen since rails flash uses an array of symbols internally which cannot be jsonified, so I'm killing that project :)

dennisreimann added a commit that referenced this pull request Jan 29, 2014
@dennisreimann dennisreimann merged commit 8dc60e5 into openid:master Jan 29, 2014
@dennisreimann
Copy link
Contributor

Thanks - and no problem this happened, we can iterate fast ;)

Having said that: I guess I'm not the best maintainer for this gem anymore. I myself am not using it in production nor am I doing very much Ruby work anymore. Would you like to step in and help us maintaining the gem? You have already made some nice contributions ad would be a good fitto keep this gem up and running I think :)

@grosser
Copy link
Contributor Author

grosser commented Jan 29, 2014

I'm not that deeply involved with it, just tried to get our session to json
:)
Someone actually building open-id related stuff / knowing about it would be
better + already got enough projects to maintain ;)

On Wed, Jan 29, 2014 at 10:40 AM, Dennis Reimann
notifications@github.comwrote:

Thanks - and no problem this happened, we can iterate fast ;)

Having said that: I guess I'm not the best maintainer for this gem
anymore. I myself am not using it in production nor am I doing very much
Ruby work anymore. Would you like to step in and help us maintaining the
gem? You have already made some nice contributions ad would be a good fitto
keep this gem up and running I think :)

Reply to this email directly or view it on GitHubhttps://github.com//pull/73#issuecomment-33615531
.

@dennisreimann
Copy link
Contributor

Alright - no problem just wanted to ask :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants