8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly

[zakkak]

7cc1371 introduced hidden classes with internal names like com/example/Foo.1234 that get changed to com.example.Foo/1234 by Class.getName() which are not properly handled by MetaUtil's toInternalName and internalNameToJava

This PR fixes this along with the corresponding test that used to work on the assumption that the internal class names didn't contain the . character and that java class names didn't contain the / character except for lambdas (which are now treated as hidden classes as well), an assumption that no longer holds.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Doug Simon (@dougxc - Committer) ⚠️ Review applies to 9093472

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7346/head:pull/7346
$ git checkout pull/7346

Update a local copy of the PR:
$ git checkout pull/7346
$ git pull https://git.openjdk.java.net/jdk pull/7346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7346

View PR using the GUI difftool:
$ git pr show -t 7346

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7346.diff

[bridgekeeper]

Hi @zakkak, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user zakkak" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[zakkak]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

@zakkak The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[jerboaa]

@zakkak Works for Red Hat is covered by the RH OCA.

[jerboaa]

I've created a bug for this here: https://bugs.openjdk.java.net/browse/JDK-8281266

[jerboaa]

I've created a bug for this here: https://bugs.openjdk.java.net/browse/JDK-8281266

@zakkak If you update the PR title to the bug synopsis the bots should add the issue just fine. I.e. change it to:

8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly

[jerboaa]

@robilad Could someone look at the OCA verification status for @zakkak please?

[robilad]

Done, thanks for the ping!

[mlbridge]

Webrevs

• 01: Full - Incremental (f0ac427c)
• 00: Full (90934723)

[jerboaa]

Done, thanks for the ping!

Thanks, Dalibor!

[jerboaa]

This looks fine to me. Perhaps @dougxc or @tkrodriguez want to have a look at this too?

[openjdk]

⚠️ @zakkak the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout fix-mandrel-355-v3
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@zakkak This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly

Reviewed-by: sgehwolf, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 344 new commits pushed to the master branch:

• c6d743f: 8282770: Set source date in jib profiles from buildId
• 5fab27e: 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes
• 65ca0a5: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
• e607287: 8282728: Serial: Remove unused BlockOffsetArray::Action
• 8b45dbd: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
• 3f0684d: 8275775: Add jcmd VM.classes to print details of all classes
• cde923d: 8282690: runtime/CommandLine/VMDeprecatedOptions.java fails after JDK-8281181
• 50eb915: 8282632: Cleanup unnecessary calls to Throwable.initCause() in java.security.jgss
• ccad392: 8282657: Code cleanup: removing double semicolons at the end of lines
• 5d5bf16: 8282567: Improve source-date handling in build system
• ... and 334 more: https://git.openjdk.java.net/jdk/compare/5ab22e88da8d79f9e19e8afffdd06206f42bab94...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa, @dougxc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jerboaa]

Still good.

[zakkak]

/integrate

[openjdk]

@zakkak
Your change (at version f0ac427) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 0cbc4b8.
Since your change was applied there have been 345 commits pushed to the master branch:

• 0f88fc1: 8282769: BSD date cannot handle all ISO 8601 formats
• c6d743f: 8282770: Set source date in jib profiles from buildId
• 5fab27e: 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes
• 65ca0a5: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
• e607287: 8282728: Serial: Remove unused BlockOffsetArray::Action
• 8b45dbd: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
• 3f0684d: 8275775: Add jcmd VM.classes to print details of all classes
• cde923d: 8282690: runtime/CommandLine/VMDeprecatedOptions.java fails after JDK-8281181
• 50eb915: 8282632: Cleanup unnecessary calls to Throwable.initCause() in java.security.jgss
• ccad392: 8282657: Code cleanup: removing double semicolons at the end of lines
• ... and 335 more: https://git.openjdk.java.net/jdk/compare/5ab22e88da8d79f9e19e8afffdd06206f42bab94...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @zakkak Pushed as commit 0cbc4b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.