fix throws information in ComputedConstant Javadoc

[danthe1st]

The current Javadoc of ComputedConstant#orElse mentions throwing a NoSuchElementException in case the element cannot be bound.
However, the Javadoc also mentions returning the passed value in that case.

If we take a look at the code for that in the computed-constants branch:

leyden/src/java.base/share/classes/jdk/internal/constant/AbstractComputedConstant.java

Line 127 in b921978

return slowPath(other, false);

and
https://github.com/openjdk/leyden/blob/b9219784cc277417dc112a7fbf652bdc021cf806/src/java.base/share/classes/jdk/internal/constant/AbstractComputedConstant.java#L161C27-L161C27
we can see that rethrow parameter is false and no NoSuchElementException is thrown:

leyden/src/java.base/share/classes/jdk/internal/constant/AbstractComputedConstant.java

Lines 183 to 186 in b921978

	if (rethrow) {
	throw new NoSuchElementException(e);
	}
	return other;

I think the @throws NoSuchElementException should be removed from ComputedConstant#orElse:
https://github.com/openjdk/leyden/blob/b9219784cc277417dc112a7fbf652bdc021cf806/src/java.base/share/classes/java/lang/ComputedConstant.java#L294C19-L294C19

I also reported this here: https://mail.openjdk.org/pipermail/leyden-dev/2023-August/000248.html

[bridgekeeper]

👋 Welcome back danthe1st! A progress list of the required criteria for merging this PR into computed-constants will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[minborg]

LGTM