Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: retworkx: A High-Performance Graph Library for Python #3867

Closed
whedon opened this issue Oct 28, 2021 · 35 comments
Closed

[PRE REVIEW]: retworkx: A High-Performance Graph Library for Python #3867

whedon opened this issue Oct 28, 2021 · 35 comments
Assignees
Labels
pre-review Python Rust Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@whedon
Copy link

whedon commented Oct 28, 2021

Submitting author: @IvanIsCoding (Ivan Carvalho)
Repository: https://github.com/Qiskit/retworkx/
Version: v0.10.2
Editor: @drvinceknight
Reviewers: @szhorvat, @inakleinbottle
Managing EiC: Kristen Thyng

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d88f8b00bb1c5dba0310a8e41a651732"><img src="https://joss.theoj.org/papers/d88f8b00bb1c5dba0310a8e41a651732/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d88f8b00bb1c5dba0310a8e41a651732/status.svg)](https://joss.theoj.org/papers/d88f8b00bb1c5dba0310a8e41a651732)

Author instructions

Thanks for submitting your paper to JOSS @IvanIsCoding. Currently, there isn't an JOSS editor assigned to your paper.

@IvanIsCoding if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Oct 28, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 28, 2021

PDF failed to compile for issue #3867 with the following error:

 Can't find any papers to compile :-(

@whedon
Copy link
Author

whedon commented Oct 28, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.43 s (601.0 files/s, 103970.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         100           2622           2640          15893
Rust                            46           1148           5645          12517
YAML                            84            179              9           1794
reStructuredText                 7            220            333            684
Markdown                         8            149              0            500
HTML                             3             42              5            281
CSS                              3             20              8            206
INI                              1              9              0             74
TOML                             4             12              0             71
Bourne Shell                     4             15             28             40
Jinja Template                   1              0              0              8
-------------------------------------------------------------------------------
SUM:                           261           4416           8668          32068
-------------------------------------------------------------------------------


Statistical information for the repository 'f86b842f0ae465d73cd497ac' was
gathered on 2021/10/28.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Bhaavan Goel                     3           329              0            1.12
Hoss Ajallooiean                 1           112              0            0.38
Ivan Carvalho                    8          4006           2211           21.18
Jielun (Chris) Chen              2          1198              2            4.09
John Lapeyre                     1           247              0            0.84
Lauren Capelluto                 1            73              0            0.25
Matthew Treinish               182         13707            707           49.11
MoAllabbad                       2           107              0            0.36
Nahum Rosa Cruz Sa               6          2655            809           11.80
Salvador de la Puent             1            22              2            0.08
Seaton Ullberg                   1            10              0            0.03
Soham Pal                        1            79              0            0.27
dependabot[bot]                  1             3              3            0.02
gadial                           2            67              2            0.24
georgios-ts                     19          2637            361           10.21

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Bhaavan Goel                303           92.1         11.4               10.89
Hoss Ajallooiean             88           78.6         11.2               12.50
Ivan Carvalho              3988           99.6          5.1                1.58
Jielun (Chris) Chen        1256          104.8          5.0                3.66
John Lapeyre                234           94.7          1.8                9.83
Lauren Capelluto             44           60.3         20.2               34.09
Matthew Treinish          10897           79.5          8.2                8.66
MoAllabbad                  106           99.1         12.0                9.43
Nahum Rosa Cruz Sa         1809           68.1          3.8                5.53
Salvador de la Puent          8           36.4          8.0                0.00
Seaton Ullberg                5           50.0         12.0                0.00
Soham Pal                    79          100.0          0.2               13.92
gadial                       23           34.3         17.9               13.04
georgios-ts                2315           87.8          3.5                5.05

@kthyng
Copy link

kthyng commented Oct 28, 2021

@whedon generate pdf from branch joss-paper

@whedon
Copy link
Author

whedon commented Oct 28, 2021

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 28, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng
Copy link

kthyng commented Oct 28, 2021

Hi @drvinceknight! Are you interested in editing this submission?

@kthyng
Copy link

kthyng commented Oct 28, 2021

@whedon invite @drvinceknight as editor

@whedon
Copy link
Author

whedon commented Oct 28, 2021

@drvinceknight has been invited to edit this submission.

@IvanIsCoding
Copy link

Thanks for considering our submission. For potential reviewers, I suggest:

  • jkbren
  • inakleinbottle
  • felipeZ
  • esteinig
  • castelao
  • TomKellyGenetics

@IvanIsCoding
Copy link

IvanIsCoding commented Oct 28, 2021

There were some discrepancies between the LaTeX output in the Github Actions (that we used) and whedon. The output should be better now.

@IvanIsCoding
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 28, 2021

PDF failed to compile for issue #3867 with the following error:

 Can't find any papers to compile :-(

@IvanIsCoding
Copy link

@whedon generate pdf from branch joss-paper

@whedon
Copy link
Author

whedon commented Oct 28, 2021

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 28, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@drvinceknight
Copy link

@whedon invite @drvinceknight as editor

Yup! Delighted :)

@drvinceknight
Copy link

@whedon assign @drvinceknight as editor

@whedon
Copy link
Author

whedon commented Oct 29, 2021

OK, the editor is @drvinceknight

@szhorvat
Copy link

szhorvat commented Nov 9, 2021

I would be interested in reviewing this. I don't know Rust though, and I am not an expert in Python. However, I am interested in graph libraries, I use network analysis libraries for my work daily, and I am a member of the igraph developer team.

@drvinceknight
Copy link

Thank @szhorvat, I will add you as a reviewer and deem to find other reviewers with expertise in Python/Rust.

@drvinceknight
Copy link

@whedon assign @szhorvat as reviewer

@whedon
Copy link
Author

whedon commented Nov 12, 2021

OK, @szhorvat is now a reviewer

@drvinceknight
Copy link

@jkbren, @inakleinbottle and @felipeZ I'm pinging you to ask if you would be able to assist with reviewing this submissions to JOSS (The Journal of Open Source Software).

JOSS publishes articles about open source research software. The submission I'd like you to review is titled: “retworkx: A High-Performance Graph Library for Python” which I believe fits within your stated interests/expertise. You can find more information at the top of this Github issue.

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

@IvanIsCoding
Copy link

@whedon generate pdf from branch joss-paper

@whedon
Copy link
Author

whedon commented Nov 15, 2021

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 15, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@inakleinbottle
Copy link

@drvinceknight I'd be happy to review that article.

@drvinceknight
Copy link

Thanks @inakleinbottle

@drvinceknight
Copy link

@whedon add @inakleinbottle as reviewer

@whedon
Copy link
Author

whedon commented Dec 1, 2021

OK, @inakleinbottle is now a reviewer

@drvinceknight
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Dec 1, 2021

OK, I've started the review over in #3968.

@whedon whedon closed this as completed Dec 1, 2021
@drvinceknight
Copy link

@szhorvat and @inakleinbottle the review has started over on #3968 where there are instructions and guidance. If you have any queries at all or if there is anything I can assist with please let me know.

@szhorvat
Copy link

szhorvat commented Dec 1, 2021

Thanks @drvinceknight. There seems to be an issue with compiling the PDF in #3968.

@editorialbot editorialbot added the Track: 7 (CSISM) Computer science, Information Science, and Mathematics label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python Rust Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

7 participants