Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: pypfilt: a particle filter for Python #6231

Closed
editorialbot opened this issue Jan 16, 2024 · 33 comments
Closed

[PRE REVIEW]: pypfilt: a particle filter for Python #6231

editorialbot opened this issue Jan 16, 2024 · 33 comments
Assignees
@tbrown122387 @diehlpk @Karangupta1994
Labels
pre-review Python Shell TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jan 16, 2024 •
edited
Loading

Submitting author: @robmoss (Rob Moss)
Repository: https://bitbucket.org/robmoss/particle-filter-for-python/
Branch with paper.md (empty if default branch): joss-paper
Version: 0.8.1
Editor: @diehlpk
Reviewers: @tbrown122387, @Karangupta1994
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d9d7da4e69f3fb13f0fb7669e935df79"><img src="https://joss.theoj.org/papers/d9d7da4e69f3fb13f0fb7669e935df79/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d9d7da4e69f3fb13f0fb7669e935df79/status.svg)](https://joss.theoj.org/papers/d9d7da4e69f3fb13f0fb7669e935df79)

Author instructions

Thanks for submitting your paper to JOSS @robmoss. Currently, there isn't a JOSS editor assigned to your paper.

@robmoss if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Jan 16, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.16 s (682.4 files/s, 134267.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          53           2997           5529           9406
reStructuredText                45           1090            728           1393
TOML                             9             82              5            420
TeX                              1             24             12            207
Markdown                         1             22              0             58
YAML                             2              9             10             40
Bourne Shell                     1              1              3              2
-------------------------------------------------------------------------------
SUM:                           112           4225           6287          11526
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 816

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/irv.12376 is OK
- 10.1017/S0950268816002053 is OK
- 10.1016/j.idm.2016.12.004 is OK
- 10.1111/1753-6405.12750 is OK
- 10.3390/tropicalmed4010012 is OK
- 10.33321/cdi.2019.43.7 is OK
- 10.7554/eLife.58785 is OK
- 10.1371/journal.pmed.1003018 is OK
- 10.3201/eid2612.202530 is OK
- 10.1038/s41598-023-35668-6 is OK
- 10.1080/10618600.1996.10474692 is OK
- 10.1007/978-1-4757-3437-9 is OK
- 10.1007/978-3-030-47845-2 is OK
- 10.7717/peerj-cs.1516 is OK
- 10.5281/zenodo.8308177 is OK

MISSING DOIs

- 10.1007/978-1-4757-3437-9_12 may be a valid DOI for title: Improving Regularised Particle Filters

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

A Short Introduction to PF: A C++ Library for Particle Filtering
Submitting author: @tbrown122387
Handling editor: @diehlpk (Active)
Reviewers: @ziotom78, @andremrsantos
Similarity score: 0.8247

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.8210

AgentPy: A package for agent-based modeling in Python
Submitting author: @JoelForamitti
Handling editor: @sbenthall (Active)
Reviewers: @jamesdamillington, @martibosch
Similarity score: 0.8200

pydynpd: A Python package for dynamic panel model
Submitting author: @dazhwu
Handling editor: @chartgerink (Active)
Reviewers: @Athene-ai, @mhu48
Similarity score: 0.8180

SiSyPHE: A Python package for the Simulation of Systems of interacting mean-field Particles with High Efficiency
Submitting author: @antoinediez
Handling editor: @pdebuyl (Active)
Reviewers: @lorenzo-rovigatti, @junghans
Similarity score: 0.8177

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

@robmoss - thanks for your submission. I'll look for an editor next.

While I do so, you could work on the possibly missing DOI that editorialbot suggests, but note that it may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

👋 @diehlpk - do you think you could edit this submission?

@danielskatz
Copy link

@editorialbot invite @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@diehlpk
Copy link
Member

diehlpk commented Jan 16, 2024

@editorialbot add @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @diehlpk is now the editor

@robmoss
Copy link

robmoss commented Jan 16, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/irv.12376 is OK
- 10.1017/S0950268816002053 is OK
- 10.1016/j.idm.2016.12.004 is OK
- 10.1111/1753-6405.12750 is OK
- 10.3390/tropicalmed4010012 is OK
- 10.33321/cdi.2019.43.7 is OK
- 10.7554/eLife.58785 is OK
- 10.1371/journal.pmed.1003018 is OK
- 10.3201/eid2612.202530 is OK
- 10.1038/s41598-023-35668-6 is OK
- 10.1080/10618600.1996.10474692 is OK
- 10.1007/978-1-4757-3437-9 is OK
- 10.1007/978-1-4757-3437-9_12 is OK
- 10.1007/978-3-030-47845-2 is OK
- 10.7717/peerj-cs.1516 is OK
- 10.5281/zenodo.8308177 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@robmoss
Copy link

robmoss commented Jan 16, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PySDM v1: particle-based cloud modeling package for warm-rain microphysics and aqueous chemistry
Submitting author: @piotrbartman
Handling editor: @dhhagan (Active)
Reviewers: @darothen, @josephhardinee
Similarity score: 0.8319

AgentPy: A package for agent-based modeling in Python
Submitting author: @JoelForamitti
Handling editor: @sbenthall (Active)
Reviewers: @jamesdamillington, @martibosch
Similarity score: 0.8301

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.8297

GCM-Filters: A Python Package for Diffusion-based Spatial Filtering of Gridded Data
Submitting author: @NoraLoose
Handling editor: @elbeejay (Active)
Reviewers: @callumrollo, @AleksiNummelin, @isgiddy
Similarity score: 0.8252

SiSyPHE: A Python package for the Simulation of Systems of interacting mean-field Particles with High Efficiency
Submitting author: @antoinediez
Handling editor: @pdebuyl (Active)
Reviewers: @lorenzo-rovigatti, @junghans
Similarity score: 0.8251

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@robmoss
Copy link

robmoss commented Jan 16, 2024

Some potential reviewers:

Some JOSS reviewers who are happy to review Python code and list "forecasting" as a topic area:

  • bbortey9
  • Karangupta1994
  • FATelarico
  • wiljnich / wiljnichepa
  • neerajdhanraj
  • kumar
  • bradyrx
  • petroniocandido

I'm struggling to think of suitable reviewers outside of those registered with JOSS, it's a challenging Venn diagram. I'll keep thinking ...

@diehlpk
Copy link
Member

diehlpk commented Jan 18, 2024

Hi @tbrown122387 do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Jan 18, 2024

Hi @ziotom78 do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Jan 18, 2024

Hi @andremrsantos do you have time to review this paper?

@andremrsantos
Copy link

Hi @andremrsantos do you have time to review this paper?

Thank you for the consideration, But I am not an expert on the manuscript subject.

@diehlpk
Copy link
Member

diehlpk commented Jan 22, 2024

Hi @bbortey9 do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Jan 22, 2024

Hi @Karangupta1994 do you have time to review this paper?

@Karangupta1994
Copy link

Karangupta1994 commented Jan 22, 2024 via email

@bbortey9
Copy link

bbortey9 commented Jan 23, 2024 via email

@tbrown122387
Copy link

Hi @tbrown122387 do you have time to review this paper?

Sure!

@diehlpk
Copy link
Member

diehlpk commented Jan 24, 2024

@editorialbot add @tbrown122387 as reviewer

@editorialbot
Copy link
Collaborator Author

@tbrown122387 added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Jan 24, 2024

@editorialbot add @Karangupta1994 as reviewer

@editorialbot
Copy link
Collaborator Author

@Karangupta1994 added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Jan 24, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6276.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbrown122387 tbrown122387

@diehlpk diehlpk

@Karangupta1994 Karangupta1994

Labels
pre-review Python Shell TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@andremrsantos @tbrown122387 @danielskatz @diehlpk @robmoss @Karangupta1994 @bbortey9 @editorialbot