Clarified DCO and CLA requirements #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobie
reviewed
Aug 15, 2024
This was referenced Sep 16, 2024
This was referenced Sep 30, 2024
|
Notes from today's CPC call: We assumed that @bensternthal would come back with an update to the PR accounting for the comments received. @bensternthal, please do let us know if you had something different in mind. |
Updated based on feebdack. Changes include: 1. Removing an auto generated TOC that was included by a visual studio plugin :| 2. Changed DCO instructions so that DCO bot is preferred but either method works.
|
@tobie Thanks for keeping me on my toes. Adjusted the PR with feedback. |
removed typo Signed-off-by: Benjamin Sternthal <ben@devpatch.com>
tobie
approved these changes
Oct 4, 2024
Resolved Tobie's suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clarifications for DCO & CLA, hoping to address #387, #632, and #778