api: Send correct notifications after assigining workflow item

* The recipient for notifications after assigning workflowitems is now
the new assignee of the workflowitem as it should be
* Added unit test to test this behaviour
* Fixed typos in other unit tests and added one test case each

CHANGELOG.md

@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Navigation on notifications page now works as expected [#272](https://github.com/openkfw/TruBudget/pull/272)
 - The link to the project/subproject is now active when the user has permissions to see it [#284](https://github.com/openkfw/TruBudget/pull/284)
 - The link to the project/subproject in fly-in notifications correctly redirects the user [#284](https://github.com/openkfw/TruBudget/pull/284)
+- When a workflow item is assigned, the new assignee gets notified [#272](https://github.com/openkfw/TruBudget/pull/272)
 
 <!-- ### Security -->
 

api/src/service/domain/workflow/project_projected_budget_delete.spec.ts

@@ -55,20 +55,31 @@ describe("Delete project projected budget: permissions", () => {
   });
 
   it("The root user doesn't need permission to delete a projected budget", async () => {
-    const result = await deleteProjectedBudget(ctx, root, projectId, "Othertestcorp", "EUR", {
-      ...baseRepository,
-      getProject: async () => ({
-        ...baseProject,
-        permissions: {},
-        projectedBudgets: [
-          {
-            organization: "Testcorp",
-            value: "10000",
-            currencyCode: "EUR",
-          },
-        ],
-      }),
-    });
+    const projectedBudget = {
+      organization: "Testcorp",
+      currencyCode: "EUR",
+    };
+    const result = await deleteProjectedBudget(
+      ctx,
+      root,
+      projectId,
+      projectedBudget.organization,
+      projectedBudget.currencyCode,
+      {
+        ...baseRepository,
+        getProject: async () => ({
+          ...baseProject,
+          permissions: {},
+          projectedBudgets: [
+            {
+              organization: projectedBudget.organization,
+              currencyCode: projectedBudget.currencyCode,
+              value: "10000",
+            },
+          ],
+        }),
+      },
+    );
 
     // No errors, despite the missing permissions:
     assert.isTrue(Result.isOk(result), (result as Error).message);
@@ -85,17 +96,69 @@ describe("Delete project projected budget: permissions", () => {
     assert.instanceOf(result, NotFound);
   });
 
-  // Test can be activated if #290 is fixed or deleted otherwise
-  // it("Deleting a projected budget fails if the projected budget cannot be found.", async () => {
-  //   const result = await deleteProjectedBudget(ctx, alice, projectId, "Somecorp", "EUR", {
-  //     ...baseRepository,
-  //     getProject: async () => ({ ...baseProject }),
-  //   });
-
-  //   // NotFound error as the project cannot be fetched:
-  //   assert.isTrue(Result.isErr(result));
-  //   // assert.instanceOf(result, NotFound);
-  // });
+  it("Deleting a projected budget does nothing if the projected budget cannot be found.", async () => {
+    const result = await deleteProjectedBudget(ctx, alice, projectId, "Somecorp", "EUR", {
+      ...baseRepository,
+      getProject: async () => ({
+        ...baseProject,
+        projectedBudgets: [
+          {
+            organization: "Testcorp",
+            currencyCode: "USD",
+            value: "10000",
+          },
+        ],
+      }),
+    });
+
+    // NotFound error as the project cannot be fetched:
+    assert.isTrue(Result.isOk(result));
+  });
+});
+
+describe("Delete project projected budget: deletion", () => {
+  it("The projected budget is not available after deletion", async () => {
+    const projectedBudget = {
+      organization: "Testcorp",
+      currencyCode: "EUR",
+    };
+    const projectedBudgetToDelete = {
+      organization: "Otherestcorp",
+      currencyCode: "EUR",
+    };
+    const result = await deleteProjectedBudget(
+      ctx,
+      alice,
+      projectId,
+      projectedBudgetToDelete.organization,
+      projectedBudgetToDelete.currencyCode,
+      {
+        ...baseRepository,
+        getProject: async () => ({
+          ...baseProject,
+          projectedBudgets: [
+            {
+              organization: projectedBudget.organization,
+              value: "10000",
+              currencyCode: projectedBudget.currencyCode,
+            },
+            {
+              organization: projectedBudgetToDelete.organization,
+              value: "10000",
+              currencyCode: projectedBudgetToDelete.currencyCode,
+            },
+          ],
+        }),
+      },
+    );
+
+    assert.isTrue(Result.isOk(result));
+    if (Result.isErr(result)) {
+      throw result;
+    }
+    const { projectedBudgets } = result;
+    assert.isTrue(projectedBudgets.length === 1);
+  });
 });
 
 describe("Deleting Projected Budgets: notifications", () => {

api/src/service/domain/workflow/project_projected_budget_update.spec.ts

@@ -8,7 +8,6 @@ import { NotFound } from "../errors/not_found";
 import { ServiceUser } from "../organization/service_user";
 import { Project } from "./project";
 import { updateProjectedBudget } from "./project_projected_budget_update";
-import { Subproject } from "./subproject";
 
 const ctx: Ctx = { requestId: "", source: "test" };
 const root: ServiceUser = { id: "root", groups: [] };
@@ -102,6 +101,45 @@ describe("Update project projected budget: permissions", () => {
   });
 });
 
+describe("Update project projected budget: updating", () => {
+  it("The projected budget is updated", async () => {
+    const projectedBudgetToUpdate = {
+      organization: "Otherestcorp",
+      value: "10000",
+      currencyCode: "EUR",
+    };
+    const updatedValue = "9999";
+    const result = await updateProjectedBudget(
+      ctx,
+      alice,
+      projectId,
+      projectedBudgetToUpdate.organization,
+      updatedValue,
+      projectedBudgetToUpdate.currencyCode,
+      {
+        ...baseRepository,
+        getProject: async () => ({
+          ...baseProject,
+          projectedBudgets: [
+            {
+              organization: projectedBudgetToUpdate.organization,
+              value: projectedBudgetToUpdate.value,
+              currencyCode: projectedBudgetToUpdate.currencyCode,
+            },
+          ],
+        }),
+      },
+    );
+
+    assert.isTrue(Result.isOk(result));
+    if (Result.isErr(result)) {
+      throw result;
+    }
+    const { projectedBudgets } = result;
+    assert.equal(projectedBudgets[0].value, updatedValue);
+  });
+});
+
 describe("Update Projected Budgets: notifications", () => {
   it("When a user updates a projected budget, a notification is issued to the assignee.", async () => {
     const result = await updateProjectedBudget(ctx, alice, projectId, "Testcorp", "9999", "EUR", {