storage-service: optimize log messages

openkfw · Oct 27, 2021 · e1aa3a6 · e1aa3a6
1 parent 11a98b0
commit e1aa3a6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/storage-service/src/index.ts b/storage-service/src/index.ts
@@ -58,6 +58,7 @@ app.use(
         var msg =
           "The CORS policy for this site does not " +
           "allow access from the specified Origin.";
+        log.debug(msg);
         return callback(new Error(msg), false);
       }
       return callback(null, true);
@@ -97,13 +98,15 @@ app.post(
   (req: DocumentUploadRequest, res: express.Response) => {
     const errors = validationResult(req);
     if (!errors.isEmpty()) {
+      log.error({ err: errors }, "Error while validating request");
       return res.status(400).json({ errors: errors.array() }).end();
     }
 
     const docId: string = req.query.docId;
     const { content, fileName } = req.body;
 
     (async () => {
+      log.debug({ req }, "Uploading document");
       const result = await uploadAsPromised(docId, content, {
         fileName,
         docId,
@@ -112,7 +115,7 @@ app.post(
     })().catch((err) => {
       if (err.code === "NoSuchBucket") {
         req.log.error(
-          err,
+          { err },
           "NoSuchBucket at /upload. Please restart storage-service to create a new bucket at minio",
         );
       }
@@ -127,6 +130,7 @@ app.get(
   (req: DocumentDownloadRequest, res: express.Response) => {
     const errors = validationResult(req);
     if (!errors.isEmpty()) {
+      req.log.error({err: errors}, "Error while validating request");
       return res.status(404).end();
     }
     const docId: string = req.query.docId;
@@ -139,6 +143,7 @@ app.get(
 
     // first get document
     (async () => {
+      req.log.debug({req}, "Downloading document");
       const result = await downloadAsPromised(docId);
 
       //check if the given secret matches the one form the metadata
@@ -150,7 +155,7 @@ app.get(
     })().catch((err) => {
       if (err.code === "NoSuchBucket") {
         req.log.error(
-          err,
+          {err},
           "NoSuchBucket at /download. Please restart storage-service to create a new bucket at minio",
         );
       }

diff --git a/storage-service/src/minio.ts b/storage-service/src/minio.ts
@@ -127,6 +127,7 @@ const download = (file: string, cb: Function) => {
       log.error({ err }, "Error during getting file object");
       cb(err);
     } else {
+      log.trace("Fetching data from stream");
       dataStream.on("data", (chunk: string) => {
         fileContent += chunk;
       });
@@ -196,7 +197,7 @@ export const establishConnection = async () => {
       break;
     } catch (err) {
       log.error(
-        err,
+        { err },
         "Problem with establishing connection to min.io and creating bucket.",
       );