Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notifications related permissions #316

Closed
kevinbader opened this issue Jun 6, 2019 · 0 comments · Fixed by #329
Closed

Remove notifications related permissions #316

kevinbader opened this issue Jun 6, 2019 · 0 comments · Fixed by #329
Milestone
TruBudget 1.2.0

Comments

@kevinbader
Copy link
Contributor

In intents.ts those three lines + related permission checks should be removed:

  // TODO: those should probably be user intents rather than global ones:
  "notification.list",
  "notification.markRead",

Reason: a user should always be allowed to list his/her own notifications. Indeed, the corresponding endpoint doesn't even allow to list another user's notifications. Furthermore, a user should always be allowed to mark his/her own notifications as "read" and we can't think of a reason why a user would ever need to mark another user's notifications as read.
mathiashoeld added a commit that referenced this issue Jun 17, 2019
@mathiashoeld
api: Remove permissions for notifications
bebb92b 
Every user should be able to:
- Read their own notifications
- Mark their own notifications as read

Currently it's not possible to list another user's notifications, so
there is no need to check any permissions related to notifications.
Therefore they are removed from the list of intents and the
documentation.

Closes #316
@mathiashoeld mathiashoeld added this to the TruBudget 1.2.0 milestone Jun 17, 2019
mathiashoeld added a commit that referenced this issue Jun 17, 2019
@mathiashoeld
api: Remove permissions for notifications
4f711cc 
Every user should be able to:
- Read their own notifications
- Mark their own notifications as read

Currently it's not possible to list another user's notifications, so
there is no need to check any permissions related to notifications.
Therefore they are removed from the list of intents and the
documentation.

Closes #316
mathiashoeld added a commit that referenced this issue Jun 17, 2019
@mathiashoeld
api: Remove permissions for notifications
6b67b7b 
Every user should be able to:
- Read their own notifications
- Mark their own notifications as read

Currently it's not possible to list another user's notifications, so
there is no need to check any permissions related to notifications.
Therefore they are removed from the list of intents and the
documentation.

Closes #316
mathiashoeld added a commit that referenced this issue Jun 17, 2019
@mathiashoeld
api: Remove permissions for notifications
219746c 
Every user should be able to:
- Read their own notifications
- Mark their own notifications as read

Currently it's not possible to list another user's notifications, so
there is no need to check any permissions related to notifications.
Therefore they are removed from the list of intents and the
documentation.

Closes #316
@mathiashoeld mathiashoeld mentioned this issue Jun 17, 2019
Merged
mathiashoeld added a commit that referenced this issue Jun 17, 2019
@mathiashoeld
api: Remove permissions for notifications
035eecb 
Every user should be able to:
- Read their own notifications
- Mark their own notifications as read

Currently it's not possible to list another user's notifications, so
there is no need to check any permissions related to notifications.
Therefore they are removed from the list of intents and the
documentation.

Closes #316
@mathiashoeld mathiashoeld modified the milestones: TruBudget 1.3.0, TruBudget 1.2.0 Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TruBudget 1.2.0
Development

Successfully merging a pull request may close this issue.

api: Remove permissions for notifications openkfw/TruBudget
2 participants
@kevinbader @mathiashoeld