Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change timestamp in history #426

Closed
mathiashoeld opened this issue Jan 29, 2020 · 4 comments · Fixed by #429
Closed

Change timestamp in history #426

mathiashoeld opened this issue Jan 29, 2020 · 4 comments · Fixed by #429
Assignees

Comments

@mathiashoeld
Copy link
Contributor

Instead of "2 hours ago" the timestamp of history items should display year, month and day of the occurrence.

@daniel-arnauer
Copy link
Contributor

Possible Solution:
Remove "fromNow()" in HistoryList.js to get absolute date

Question: Should this change also applied for notifacations (NotificationListItems.js) ?

@daniel-arnauer
Copy link
Contributor

daniel-arnauer commented Jan 30, 2020

Quick Solution:

Change
secondary={dayjs(eventTime).fromNow()}
to
secondary={dayjs(eventTime).format("MM.DD.YYYY HH:MM")}

Should the format depend on selected language?

@mathiashoeld
Copy link
Contributor Author

Quick Solution:

Change
secondary={dayjs(eventTime).fromNow()}
to
secondary={dayjs(eventTime).format("MM.DD.YYYY HH:MM")}

Should the format depend on selected language?

this should suffice. please also update the format of the messages as well.

@Stezido
Copy link
Contributor

Stezido commented Feb 6, 2020

We should only display day, month and year since a exact timestamp is not important and it's easier to handle according to time shifts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants