Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Format of timestamp in history and notification #429

Merged
merged 3 commits into from
Feb 28, 2020
Merged

Conversation

daniel-arnauer
Copy link
Contributor

@daniel-arnauer daniel-arnauer commented Feb 5, 2020

New Format according to Issue #426
Old Timestamp depends on current time and is set relative to it (e.g: "a minute ago")
New Timestamp shows absolute values (e.g: "15.01.2020 16:48")

Closes #426

@daniel-arnauer daniel-arnauer self-assigned this Feb 5, 2020
@openkfwCI
Copy link

openkfwCI commented Feb 5, 2020

NotesTime
Note for Reviewer: E2E tests on remote server succeededFri, 28 Feb 2020 09:15:12 +0000

Generated by E2E-Test

Copy link
Contributor

@Stezido Stezido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move the timestamp format to a place where we can easily edit it later.

e2e-test/cypress/integration/timestamp_spec.js Outdated Show resolved Hide resolved
frontend/src/pages/Common/HistoryList.js Outdated Show resolved Hide resolved
frontend/src/pages/Notifications/NotificationListItems.js Outdated Show resolved Hide resolved
@daniel-arnauer daniel-arnauer force-pushed the new-timestamp branch 5 times, most recently from 29832fe to cdb0f24 Compare February 10, 2020 10:02
frontend/src/helper.js Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Stezido Stezido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. You can merge after cleanup commit messages.

@Stezido Stezido removed their assignment Feb 20, 2020
@daniel-arnauer daniel-arnauer force-pushed the new-timestamp branch 2 times, most recently from f81a91f to 5c89ac8 Compare February 27, 2020 10:08
@Stezido Stezido removed their assignment Feb 28, 2020
@Stezido Stezido merged commit 5f45140 into master Feb 28, 2020
@mathiashoeld mathiashoeld deleted the new-timestamp branch March 10, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change timestamp in history
3 participants