Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename environmental variable "PORT" SP 0.5 #999

Closed
daniel-arnauer opened this issue Oct 11, 2021 · 2 comments · Fixed by #1168
Closed

Rename environmental variable "PORT" SP 0.5 #999

daniel-arnauer opened this issue Oct 11, 2021 · 2 comments · Fixed by #1168
Assignees
Labels
api Indicates api related issue or feature breaking change Indicates this will require a breaking change bug Something isn't working good first issue Good for newcomers

Comments

@daniel-arnauer
Copy link
Contributor

daniel-arnauer commented Oct 11, 2021

Description 😯

The env var PORT is used in the API and excel-export project to define the port. This is confusing when using an .env file for multiple services (like the .env file in dev or operation setup) .

Solution

Rename PORT in API to API_PORT and in excel-export to EXCEL_EXPORT_PORT.

Also rename API_HOST to MASTER_API_HOST and API_PORT (the current) to MASTER_API_PORT and API_PROTO to MASTER_API_PROTO

This is a breaking change for existing deployments!

Your Environment 🌎

v1.26.0

@daniel-arnauer daniel-arnauer added bug Something isn't working good first issue Good for newcomers breaking change Indicates this will require a breaking change labels Oct 11, 2021
@daniel-arnauer daniel-arnauer added this to the TruBudget 2.0.0 milestone Oct 11, 2021
@issuelabeler issuelabeler bot added the api Indicates api related issue or feature label Oct 11, 2021
@Stezido
Copy link
Contributor

Stezido commented May 4, 2022

We want to use PORT for every service as own port env var name.
Renaming API_HOST would lead to even more confusion because API_HOST is the external api host of another network for the blockchain service. When a node is started as "master"- node it wouldn't need the MASTER_API_HOST env var - that's confusing

@Stezido Stezido changed the title Rename environmental variable "PORT" Rename environmental variable "PORT" SP 0.5 May 4, 2022
@georgimld
Copy link
Collaborator

keep format of env vars for enabled services consistent:

e.g. DOCUMENT_FEATURE_ENABLED= true vs DOCUMENT_SERVICE=enabled

Should always be: XX_SERVICE_ENABLED=true

@georgimld georgimld self-assigned this May 23, 2022
@georgimld georgimld mentioned this issue May 31, 2022
6 tasks
@Stezido Stezido closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Indicates api related issue or feature breaking change Indicates this will require a breaking change bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants